Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1693302

Re: [PATCH 1/2] platform/x86: peaq-wmi: select INPUT_POLLDEV

Show all headers | View raw

On Thu, Jul 20, 2017 at 06:00:50PM +0200, Arnd Bergmann wrote:
> The new driver fails to build without INPUT_POLLDEV
> 
> drivers/platform/x86/peaq-wmi.o: In function `peaq_wmi_exit':
> peaq-wmi.c:(.exit.text+0x1c): undefined reference to `input_unregister_polled_device'
> drivers/platform/x86/peaq-wmi.o: In function `peaq_wmi_init':
> peaq-wmi.c:(.init.text+0x23): undefined reference to `input_allocate_polled_device'
> peaq-wmi.c:(.init.text+0x18e): undefined reference to `input_register_polled_device'
> 
> For some reason, all other drivers that need this use 'select'
> here rather than 'depends on', so I'm doing the same.
> 
> Fixes: 13bb0fd5519d ("platform/x86: peaq-wmi: Add new peaq-wmi driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Queued to fixes branch for 4.13-rcX. I'll leave patch 2/2 to andy since you
worked that one together already.

-- 
Darren Hart
VMware Open Source Technology Center

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] platform/x86: peaq-wmi: select INPUT_POLLDEV Arnd Bergmann <arnd@arndb.de> - 2017-07-20 18:10 +0200
  [PATCH 2/2] platform/x86: alienware-wmi: fix format string overflow warning Arnd Bergmann <arnd@arndb.de> - 2017-07-20 18:10 +0200
    Re: [PATCH 2/2] platform/x86: alienware-wmi: fix format string  overflow warning Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-07-24 11:30 +0200
      Re: [PATCH 2/2] platform/x86: alienware-wmi: fix format string  overflow warning Arnd Bergmann <arnd@arndb.de> - 2017-07-25 09:30 +0200
  Re: [PATCH 1/2] platform/x86: peaq-wmi: select INPUT_POLLDEV Darren Hart <dvhart@infradead.org> - 2017-07-21 02:10 +0200

csiph-web