Re: [RESEND PATCH] sparc: defconfig: Cleanup from old Kconfig options

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [RESEND PATCH] sparc: defconfig: Cleanup from old Kconfig options
Date	Thu, 20 Jul 2017 21:40:01 +0200
Message-ID	<u5psJ-3ei-1@gated-at.bofh.it> (permalink)
References	<u5bSP-2zR-29@gated-at.bofh.it> <u5iUi-7pn-23@gated-at.bofh.it> <u5odj-2wG-3@gated-at.bofh.it>
X-Mailer	Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO)
MIME-Version	1.0
Content-Type	Text/Plain; charset=us-ascii
Content-Transfer-Encoding	7bit
X-Greylist	Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 20 Jul 2017 12:38:05 -0700 (PDT)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	46
Organization	linux.* mail to news gateway
X-Original-Cc	sam@ravnborg.org, linux-kernel@vger.kernel.org, sparclinux@vger.kernel.org
X-Original-Date	Thu, 20 Jul 2017 12:38:04 -0700 (PDT)
X-Original-Message-ID	<20170720.123804.318219961537845081.davem@davemloft.net>
X-Original-References	<1500526855-4132-1-git-send-email-krzk@kernel.org> <20170720123633.GA7465@ravnborg.org> <20170720181124.GA2874@kozik-book>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1693188

Show key headers only | View raw

From: Krzysztof Kozlowski <krzk@kernel.org>
Date: Thu, 20 Jul 2017 20:11:24 +0200

> On Thu, Jul 20, 2017 at 02:36:33PM +0200, Sam Ravnborg wrote:
>> On Thu, Jul 20, 2017 at 07:00:55AM +0200, Krzysztof Kozlowski wrote:
>> > Remove old, dead Kconfig options (in order appearing in this commit):
>> >  - EXPERIMENTAL is gone since v3.9;
>> >  - INET_LRO: commit 7bbf3cae65b6 ("ipv4: Remove inet_lro library");
>> >  - AUTOFS_FS: commit 561c5cf9236a ("staging: Remove autofs3");
>> >  - RCU_CPU_STALL_DETECTOR: commit a00e0d714fbd ("rcu: Remove conditional
>> >    compilation for RCU CPU stall warnings");
>> >  - USB_DEVICE_CLASS: commit 007bab91324e ("USB: remove
>> >    CONFIG_USB_DEVICE_CLASS");
>> >  - SYSCTL_SYSCALL_CHECK: commit 7c60c48f58a7 ("sysctl: Improve the
>> >    sysctl sanity checks");
>> > 
>> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
>> > Acked-by: David S. Miller <davem@davemloft.net>
>> 
>> Hi Krzysztof.
>> 
>> This looks like a manually edited defconfig.
>> A better approch would be to do:
>> $ make ARCH=sparc64 sparc64_defconfig
>> $ make ARCH=sparc64 savedefconfig
>> 
>> And then to check the generated defconfig.
>> Same for sparc32.
> 
> Actually this was generated with sed instead of defconfig on purpose -
> as part of my bigger cleanup starting from ARM [1]. In case of
> defconfigs for my platform we wanted to preserve the explanation why
> things are disappearing, not only to savedefconfig. Indeed this brought
> up that few items from savedefconfig would be gone but should be
> replaced with different (new) items.
> 
> Anyway this way you have a full control and explanation why things are
> being changed. After this you can always run defconfig to reorganize and
> clean up.
> 
> [1] https://www.linux-mips.org/archives/linux-mips/2017-06/msg00255.html

Yeah I guess this is OK for now.  But we should do a tool based regen at
some point soon.

Applied, thanks.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[RESEND PATCH] sparc: defconfig: Cleanup from old Kconfig options Krzysztof Kozlowski <krzk@kernel.org> - 2017-07-20 07:10 +0200
  Re: [RESEND PATCH] sparc: defconfig: Cleanup from old Kconfig options Sam Ravnborg <sam@ravnborg.org> - 2017-07-20 14:40 +0200
    Re: [RESEND PATCH] sparc: defconfig: Cleanup from old Kconfig options Krzysztof Kozlowski <krzk@kernel.org> - 2017-07-20 20:20 +0200
      Re: [RESEND PATCH] sparc: defconfig: Cleanup from old Kconfig  options David Miller <davem@davemloft.net> - 2017-07-20 21:40 +0200

csiph-web