Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1693200
| From | Keith Busch <keith.busch@intel.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v3 3/3] nvme: wwid_show: strip trailing 0-bytes |
| Date | 2017-07-20 22:10 +0200 |
| Message-ID | <u5pVM-3D7-13@gated-at.bofh.it> (permalink) |
| References | <u5mEx-1vc-7@gated-at.bofh.it> <u5mEy-1vc-21@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Thu, Jul 20, 2017 at 06:34:02PM +0200, Martin Wilck wrote: > Some broken targets (such as the current Linux target) pad > model or serial fields with 0-bytes rather than spaces. The > NVME spec disallows 0 bytes in "ASCII" fields. > Thus strip trailing 0-bytes, too. Also make sure that we get no > underflow for pathological input. > > Signed-off-by: Martin Wilck <mwilck@suse.com> > Reviewed-by: Hannes Reinecke <hare@suse.de> > Acked-by: Christoph Hellwig <hch@lst.de> Looks good. Reviewed-by: Keith Busch <keith.busch@intel.com>
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v3 0/3] Improve readbility of NVME "wwid" attribute Martin Wilck <mwilck@suse.com> - 2017-07-20 18:40 +0200
[PATCH v3 2/3] nvmet: identify controller: improve standard compliance Martin Wilck <mwilck@suse.com> - 2017-07-20 18:40 +0200
[PATCH v3 3/3] nvme: wwid_show: strip trailing 0-bytes Martin Wilck <mwilck@suse.com> - 2017-07-20 18:40 +0200
Re: [PATCH v3 3/3] nvme: wwid_show: strip trailing 0-bytes Keith Busch <keith.busch@intel.com> - 2017-07-20 22:10 +0200
[PATCH v3 1/3] string.h: add memcpy_and_pad() Martin Wilck <mwilck@suse.com> - 2017-07-20 18:40 +0200
csiph-web