Re: [PATCH 2/2] sparc64: Use cpu_poke to resume idle cpu

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] sparc64: Use cpu_poke to resume idle cpu
Date	2017-07-20 22:00 +0200
Message-ID	<u5pM6-3kJ-1@gated-at.bofh.it> (permalink)
References	<u14wy-6ML-7@gated-at.bofh.it> <u14wy-6ML-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Vijay Kumar <vijay.ac.kumar@oracle.com>
Date: Sat,  8 Jul 2017 14:23:44 -0600

> diff --git a/arch/sparc/kernel/hvapi.c b/arch/sparc/kernel/hvapi.c
> index 2677312..0b070d5 100644
> --- a/arch/sparc/kernel/hvapi.c
> +++ b/arch/sparc/kernel/hvapi.c
> @@ -189,7 +189,7 @@ void __init sun4v_hvapi_init(void)
>  
>  	group = HV_GRP_CORE;
>  	major = 1;
> -	minor = 1;
> +	minor = 6; /* CPU POKE */
>  	if (sun4v_hvapi_register(group, major, &minor))
>  		goto bad;

That CPU POKE comment will not stand the test of time, please remove it.

> +	/* Use cpu poke to resume idle cpu if supported*/

Please put a space at the end of the comment and before the "*/"

> +		/*cpu poke is registered. */

Please put a space at the beginning of the comment.

And you should decide which way you want to consistently write.
Either capitalize the first word and finish the sentence with
a '.', or don't.  Do it the same way each time.

Thanks.

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 2/2] sparc64: Use cpu_poke to resume idle cpu David Miller <davem@davemloft.net> - 2017-07-20 22:00 +0200
  Re: [PATCH 2/2] sparc64: Use cpu_poke to resume idle cpu Vijay Kumar <vijay.ac.kumar@oracle.com> - 2017-07-21 04:50 +0200

csiph-web