Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1693110

Re: [alsa-devel] [PATCH v3] ASoC: sgtl5000: add avc support

Show all headers | View raw

On 07/20/2017 07:27 PM, Fabio Estevam wrote:
> Hi Richard,
>
> On Thu, Jul 20, 2017 at 2:25 PM, Richard Leitner <dev@g0hl1n.net> wrote:
>
>> Does this occur only on reboot or everytime the driver tries to read the AVC
>> threshold (avc_get_threshold)?
>> Are you able to set the AVC threshold (using amixer)?
>
> I am not even using the codec. I just run 'reboot' and the problem happens.
>
> The following change fixes the 'reboot' issue for me. Could you please try it?
>
> --- a/sound/soc/codecs/sgtl5000.c
> +++ b/sound/soc/codecs/sgtl5000.c
> @@ -409,7 +409,7 @@ static int dac_put_volsw(struct snd_kcontrol *kcontrol,
>  static int avc_get_threshold(struct snd_kcontrol *kcontrol,
>                              struct snd_ctl_elem_value *ucontrol)
>  {
> -       struct snd_soc_codec *codec = snd_kcontrol_chip(kcontrol);
> +       struct snd_soc_codec *codec = snd_soc_kcontrol_codec(kcontrol);

Thank you for spotting this! That works of course.

I'm sorry, it seems I messed something up during copy/paste for my own 
backport version of this patch. Seems like I tested and sent a different 
version of the patch... That definitely shouldn't have happened :-(

Do you want to send that patch or should I?

Thank you again Fabio!

regards,
Richard.L

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [alsa-devel] [PATCH v3] ASoC: sgtl5000: add avc support Fabio Estevam <festevam@gmail.com> - 2017-07-20 19:20 +0200
  Re: [alsa-devel] [PATCH v3] ASoC: sgtl5000: add avc support Fabio Estevam <festevam@gmail.com> - 2017-07-20 19:30 +0200
    Re: [alsa-devel] [PATCH v3] ASoC: sgtl5000: add avc support Richard Leitner <dev@g0hl1n.net> - 2017-07-20 19:40 +0200
      Re: [alsa-devel] [PATCH v3] ASoC: sgtl5000: add avc support Richard Leitner <dev@g0hl1n.net> - 2017-07-20 19:50 +0200
      Re: [alsa-devel] [PATCH v3] ASoC: sgtl5000: add avc support Fabio Estevam <festevam@gmail.com> - 2017-07-20 19:50 +0200
  Re: [alsa-devel] [PATCH v3] ASoC: sgtl5000: add avc support Richard Leitner <dev@g0hl1n.net> - 2017-07-20 19:30 +0200

csiph-web