Re: [PATCH v3 00/23] Qualcomm 8x16 Camera Subsystem driver

Path	csiph.com!news.redatomik.org!aioe.org!bofh.it!news.nic.it!robomod
From	Sakari Ailus <sakari.ailus@iki.fi>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 00/23] Qualcomm 8x16 Camera Subsystem driver
Date	Thu, 20 Jul 2017 17:30:03 +0200
Message-ID	<u5lyP-QM-27@gated-at.bofh.it> (permalink)
References	<u4bBw-3PU-3@gated-at.bofh.it>
X-Original-To	Todor Tomov <todor.tomov@linaro.org>
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	NeoMutt/20170113 (1.7.2)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	30
Organization	linux.* mail to news gateway
X-Original-Cc	mchehab@kernel.org, hans.verkuil@cisco.com, javier@osg.samsung.com, s.nawrocki@samsung.com, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org
X-Original-Date	Thu, 20 Jul 2017 18:25:35 +0300
X-Original-Message-ID	<20170720152535.crxlxhirtlv23rjr@valkosipuli.retiisi.org.uk>
X-Original-References	<1500287629-23703-1-git-send-email-todor.tomov@linaro.org>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1693036

Show key headers only | View raw

Hi Todor,

On Mon, Jul 17, 2017 at 01:33:26PM +0300, Todor Tomov wrote:
> This patchset adds basic support for the Qualcomm Camera Subsystem found
> on Qualcomm MSM8916 and APQ8016 processors.
> 
> The driver implements V4L2, Media controller and V4L2 subdev interfaces.
> Camera sensor using V4L2 subdev interface in the kernel is supported.
> 
> The driver is implemented using as a reference the Qualcomm Camera
> Subsystem driver for Android as found in Code Aurora [1].
> 
> The driver is tested on Dragonboard 410C (APQ8016) with one and two
> OV5645 camera sensors. media-ctl [2] and yavta [3] applications were
> used for testing. Also Gstreamer 1.10.4 with v4l2src plugin is supported.
> 
> More information is present in the document added by the third patch.

After addressing the comments (please pay attention especially those
affecting the user space API behaviour) you can add:

Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>

Let me know if you have any further questions on the individual comments.

-- 
Regards,

Sakari Ailus
e-mail: sakari.ailus@iki.fi	XMPP: sailus@retiisi.org.uk

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v3 00/23] Qualcomm 8x16 Camera Subsystem driver Sakari Ailus <sakari.ailus@iki.fi> - 2017-07-20 17:30 +0200
  Re: [PATCH v3 00/23] Qualcomm 8x16 Camera Subsystem driver Todor Tomov <todor.tomov@linaro.org> - 2017-07-21 10:00 +0200

csiph-web