Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1692969
| From | Liviu Dudau <Liviu.Dudau@arm.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] drm/i2c: tda998x: Fix lockdep warning about possible circular dependency |
| Date | 2017-07-20 16:20 +0200 |
| Message-ID | <u5kt4-bb-7@gated-at.bofh.it> (permalink) |
| References | <u5hvd-6vT-17@gated-at.bofh.it> <u5hYg-6H9-27@gated-at.bofh.it> <u5i7T-6Lf-11@gated-at.bofh.it> <u5jdE-7zI-7@gated-at.bofh.it> <u5jnk-7Tm-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Thu, Jul 20, 2017 at 02:08:29PM +0100, Russell King - ARM Linux wrote:
> On Thu, Jul 20, 2017 at 01:54:04PM +0100, Liviu Dudau wrote:
> > On Thu, Jul 20, 2017 at 12:44:49PM +0100, Russell King - ARM Linux wrote:
> > > Actually, scrub that idea - drm_helper_probe_single_connector_modes()
> > > calls drm_edid_to_eld() for these cases anyway, so we must call
> > > drm_helper_probe_single_connector_modes() with the audio_mutex held.
> >
> > OK, so the lockdep warning is spurious?
>
> I don't think so. I think there's two ways to solve this:
>
> 1. replace the audio_mutex in tda998x_audio_get_eld() and
> tda998x_connector_fill_modes() with a new mutex (eld_mutex) to
> protect just the ELD.
>
> 2. remove the mutex from these two functions, and take the connection_mutex
> modeset lock in tda998x_audio_get_eld().
>
> However, I don't have a view on which would be best.
If you don't mind, I took the liberty of picking option 2, just because
I don't like adding new locks when existing ones might do the job.
v2 patch on the way shortly.
Best regards,
Liviu
>
> --
> RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
> FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
> according to speedtest.net.
--
====================
| I would like to |
| fix the world, |
| but they're not |
| giving me the |
\ source code! /
---------------
¯\_(ツ)_/¯
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] drm/i2c: tda998x: Fix lockdep warning about possible circular dependency Liviu Dudau <Liviu.Dudau@arm.com> - 2017-07-20 13:10 +0200
Re: [PATCH] drm/i2c: tda998x: Fix lockdep warning about possible circular dependency Russell King - ARM Linux <linux@armlinux.org.uk> - 2017-07-20 13:40 +0200
Re: [PATCH] drm/i2c: tda998x: Fix lockdep warning about possible circular dependency Russell King - ARM Linux <linux@armlinux.org.uk> - 2017-07-20 13:50 +0200
Re: [PATCH] drm/i2c: tda998x: Fix lockdep warning about possible circular dependency Liviu Dudau <Liviu.Dudau@arm.com> - 2017-07-20 15:00 +0200
Re: [PATCH] drm/i2c: tda998x: Fix lockdep warning about possible circular dependency Russell King - ARM Linux <linux@armlinux.org.uk> - 2017-07-20 15:10 +0200
Re: [PATCH] drm/i2c: tda998x: Fix lockdep warning about possible circular dependency Liviu Dudau <Liviu.Dudau@arm.com> - 2017-07-20 16:20 +0200
Re: [PATCH] drm/i2c: tda998x: Fix lockdep warning about possible circular dependency Russell King - ARM Linux <linux@armlinux.org.uk> - 2017-07-20 16:30 +0200
Re: [PATCH] drm/i2c: tda998x: Fix lockdep warning about possible circular dependency Liviu Dudau <Liviu.Dudau@arm.com> - 2017-07-20 16:50 +0200
Re: [PATCH] drm/i2c: tda998x: Fix lockdep warning about possible circular dependency Daniel Vetter <daniel.vetter@ffwll.ch> - 2017-07-20 17:00 +0200
Re: [PATCH] drm/i2c: tda998x: Fix lockdep warning about possible circular dependency Liviu Dudau <Liviu.Dudau@arm.com> - 2017-07-20 17:10 +0200
csiph-web