Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1692565
| From | Borislav Petkov <bp@alien8.de> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 7/7] x86: microcode: constify attribute_group structures. |
| Date | 2017-07-20 10:40 +0200 |
| Message-ID | <u5fa2-4Lf-33@gated-at.bofh.it> (permalink) |
| References | <u5e4i-41p-15@gated-at.bofh.it> <u5e4i-41p-31@gated-at.bofh.it> <u5eQG-4Bm-7@gated-at.bofh.it> <u5eQG-4Bm-9@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Thu, Jul 20, 2017 at 01:48:17PM +0530, Arvind Yadav wrote:
> It's just show, how much bytes move from data segment to text segment.
> ~arvind
3614 545 1560 5719 1657 x86/kernel/cpu/microcode/core.o
3614 + 545 = 4159
3742 417 1560 5719 1657 x86/kernel/cpu/microcode/core.o
3742 + 417 = 4159
3742 - 3614 = 128
So 128 bytes moved to text.
I fail to see how this is relevant. Your commit message contains not
really relevant info for such a simple change. Rather, it should just be
a one-liner:
"Constify attribute_group structs because they don't change at runtime."
That's it.
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
--
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/7] constify x86 attribute_group structures. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-07-20 09:30 +0200
[PATCH 3/7] perf: x86: intel: uncore_snb: constify attribute_group structures. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-07-20 09:30 +0200
[PATCH 7/7] x86: microcode: constify attribute_group structures. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-07-20 09:30 +0200
Re: [PATCH 7/7] x86: microcode: constify attribute_group structures. Borislav Petkov <bp@alien8.de> - 2017-07-20 10:20 +0200
Re: [PATCH 7/7] x86: microcode: constify attribute_group structures. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-07-20 10:20 +0200
Re: [PATCH 7/7] x86: microcode: constify attribute_group structures. Borislav Petkov <bp@alien8.de> - 2017-07-20 10:40 +0200
Re: [PATCH 7/7] x86: microcode: constify attribute_group structures. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-07-20 11:10 +0200
Re: [PATCH 7/7] x86: microcode: constify attribute_group structures. Borislav Petkov <bp@alien8.de> - 2017-07-20 12:40 +0200
Re: [PATCH 7/7] x86: microcode: constify attribute_group structures. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-07-20 13:10 +0200
[PATCH 6/7] x86: therm_throt: constify attribute_group structures. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-07-20 09:30 +0200
csiph-web