Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1692660
| From | tip-bot for Jin Yao <tipbot@zytor.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [tip:perf/core] perf report: Enable finding kernel inline functions |
| Date | 2017-07-20 11:10 +0200 |
| Message-ID | <u5fD6-5dz-79@gated-at.bofh.it> (permalink) |
| References | <u4zXc-2qo-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Commit-ID: 8b8ef2d74dec305b99dd43ec71d3ba2f502100b9 Gitweb: http://git.kernel.org/tip/8b8ef2d74dec305b99dd43ec71d3ba2f502100b9 Author: Jin Yao <yao.jin@linux.intel.com> AuthorDate: Wed, 19 Jul 2017 04:31:32 +0800 Committer: Arnaldo Carvalho de Melo <acme@redhat.com> CommitDate: Tue, 18 Jul 2017 23:14:27 -0300 perf report: Enable finding kernel inline functions Currently perf supports a mode to query inline stack. It works well for finding user space inline functions but it doesn't work for kernel ones, due to some unnecessary check. This patch removes these unnecessary checks. Now kernel inline functions can be reported. For example: perf report --inline -g func --stdio |--46.19%--do_huge_pmd_anonymous_page | do_huge_pmd_anonymous_page (inline) | __do_huge_pmd_anonymous_page (inline) | __SetPageUptodate (inline) | __set_bit (inline) The result is compared with the output of addr2line. They match. Signed-off-by: Yao Jin <yao.jin@linux.intel.com> Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com> Cc: Andi Kleen <ak@linux.intel.com> Cc: Jiri Olsa <jolsa@kernel.org> Cc: Kan Liang <kan.liang@intel.com> Cc: Milian Wolff <milian.wolff@kdab.com> Cc: Peter Zijlstra <peterz@infradead.org> Link: http://lkml.kernel.org/r/1500409892-15904-1-git-send-email-yao.jin@linux.intel.com Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> --- tools/perf/ui/browsers/hists.c | 3 --- tools/perf/ui/stdio/hist.c | 3 --- 2 files changed, 6 deletions(-) diff --git a/tools/perf/ui/browsers/hists.c b/tools/perf/ui/browsers/hists.c index 69f4570..f4bc246 100644 --- a/tools/perf/ui/browsers/hists.c +++ b/tools/perf/ui/browsers/hists.c @@ -166,9 +166,6 @@ static struct inline_node *inline_node__create(struct map *map, u64 ip) if (dso == NULL) return NULL; - if (dso->kernel != DSO_TYPE_USER) - return NULL; - node = dso__parse_addr_inlines(dso, map__rip_2objdump(map, ip)); diff --git a/tools/perf/ui/stdio/hist.c b/tools/perf/ui/stdio/hist.c index 42e432b..2df8eb1 100644 --- a/tools/perf/ui/stdio/hist.c +++ b/tools/perf/ui/stdio/hist.c @@ -35,9 +35,6 @@ static size_t inline__fprintf(struct map *map, u64 ip, int left_margin, if (dso == NULL) return 0; - if (dso->kernel != DSO_TYPE_USER) - return 0; - node = dso__parse_addr_inlines(dso, map__rip_2objdump(map, ip)); if (node == NULL)
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[PATCH] perf report: Enable finding the kernel inline function Jin Yao <yao.jin@linux.intel.com> - 2017-07-18 14:40 +0200 Re: [PATCH] perf report: Enable finding the kernel inline function Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-07-18 18:00 +0200 [tip:perf/core] perf report: Enable finding kernel inline functions tip-bot for Jin Yao <tipbot@zytor.com> - 2017-07-20 11:10 +0200
csiph-web