Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1692530

[PATCH 1/3] uuid: fix incorrect uuid_equal conversion in test_uuid_test

Path csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From Christoph Hellwig <hch@lst.de>
Newsgroups linux.kernel
Subject [PATCH 1/3] uuid: fix incorrect uuid_equal conversion in test_uuid_test
Date Thu, 20 Jul 2017 10:00:02 +0200
Message-ID <u5exk-4e2-23@gated-at.bofh.it> (permalink)
References <u5exj-4e2-3@gated-at.bofh.it>
X-Original-To Andy Shevchenko <andriy.shevchenko@linux.intel.com>, Amir Goldstein <amir73il@gmail.com>, Andreas Noever <andreas.noever@gmail.com>, Michael Jamet <michael.jamet@intel.com>, Mika Westerberg <mika.westerberg@linux.intel.com>, Yehezkel Bernat <yehezkel.bernat@intel.com>
Dkim-Signature v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=References:In-Reply-To:Message-Id: Date:Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=mjNAieQhoKWbxPT76u9zhQ8k4wAcGzJ4oBlcroP/YoQ=; b=CzS0ciWBKvVPquaicSIbnvZ9Z sZwr0pOabIuL7c4MyUQiIiCDbVVK3i0pN7gMqWhAZlvW9DM+V8K7SVdYiBrBaiycgUHh67PCv/Wkn qbWgA8I8YRUvSJc3aFsdpmD+ZckmjehGR+WDPbqXGpZjriNBnvMzElDXcmAal7/BxFoSDj1d/AjPQ DTmQ7Sndig33Jn1tF8w94DLgMOrcP0Oq9g3JLIIcE5MFSmkdWQtMDGB049DNOFMhL1J16XH89lFOf 5NYZkwhfB3gI2nozQLPZ9XMp1hRFHIEt6xsxiYkxEdCymiK5dZ0bUp5YuLhplCsLe8uZKQhhfXlOg Regddb1rQ==;
X-Mailer git-send-email 2.11.0
X-Srs-Rewrite SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 22
Organization linux.* mail to news gateway
X-Original-Cc linux-kernel@vger.kernel.org
X-Original-Date Thu, 20 Jul 2017 09:56:22 +0200
X-Original-Message-ID <20170720075624.25619-2-hch@lst.de>
X-Original-References <20170720075624.25619-1-hch@lst.de>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1692530

Show key headers only | View raw


Fixes: df33767d ("uuid: hoist helpers uuid_equal() and uuid_copy() from xfs")
Reported-by: kernel test robot <xiaolong.ye@intel.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 lib/test_uuid.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/test_uuid.c b/lib/test_uuid.c
index 478c049630b5..cd819c397dc7 100644
--- a/lib/test_uuid.c
+++ b/lib/test_uuid.c
@@ -82,7 +82,7 @@ static void __init test_uuid_test(const struct test_uuid_data *data)
 		test_uuid_failed("conversion", false, true, data->uuid, NULL);
 
 	total_tests++;
-	if (uuid_equal(&data->be, &be)) {
+	if (!uuid_equal(&data->be, &be)) {
 		sprintf(buf, "%pUb", &be);
 		test_uuid_failed("cmp", false, true, data->uuid, buf);
 	}
-- 
2.11.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread


Thread

[PATCH 1/3] uuid: fix incorrect uuid_equal conversion in test_uuid_test Christoph Hellwig <hch@lst.de> - 2017-07-20 10:00 +0200
  Re: [PATCH 1/3] uuid: fix incorrect uuid_equal conversion in test_uuid_test Amir Goldstein <amir73il@gmail.com> - 2017-07-20 11:00 +0200

csiph-web