Re: [PATCH v2] KVM: VMX: Fix invalid guest state detection after task-switch emulation

Path	csiph.com!news.redatomik.org!aioe.org!bofh.it!news.nic.it!robomod
From	Radim Krčmář <rkrcmar@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] KVM: VMX: Fix invalid guest state detection after task-switch emulation
Date	Thu, 20 Jul 2017 10:00:01 +0200
Message-ID	<u5exj-4e2-5@gated-at.bofh.it> (permalink)
References	<u56T7-7j2-3@gated-at.bofh.it>
Dmarc-Filter	OpenDMARC Filter v1.3.2 mx1.redhat.com 6FAAD7CB86
Authentication-Results	ext-mx02.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
Authentication-Results	ext-mx02.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=rkrcmar@redhat.com
Dkim-Filter	OpenDKIM Filter v2.11.0 mx1.redhat.com 6FAAD7CB86
MIME-Version	1.0
Content-Type	text/plain; charset=utf-8
Content-Disposition	inline
Content-Transfer-Encoding	8bit
X-Scanned-By	MIMEDefang 2.79 on 10.5.11.15
X-Greylist	Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Thu, 20 Jul 2017 07:57:09 +0000 (UTC)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	55
Organization	linux.* mail to news gateway
X-Original-Cc	linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Paolo Bonzini <pbonzini@redhat.com>, Wanpeng Li <wanpeng.li@hotmail.com>, Nadav Amit <nadav.amit@gmail.com>
X-Original-Date	Thu, 20 Jul 2017 09:57:05 +0200
X-Original-Message-ID	<20170720075705.GA30711@potion>
X-Original-References	<1500507602-105830-1-git-send-email-wanpeng.li@hotmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1692527

Show key headers only | View raw

2017-07-19 16:40-0700, Wanpeng Li:
> From: Wanpeng Li <wanpeng.li@hotmail.com>
> 
> This can be reproduced by EPT=1, unrestricted_guest=N, emulate_invalid_state=Y 
> or EPT=0, the trace of kvm-unit-tests/taskswitch2.flat is like below, it tries 
> to emulate invalid guest state task-switch:
> 
> kvm_exit: reason TASK_SWITCH rip 0x0 info 40000058 0
> kvm_emulate_insn: 42000:0:0f 0b (0x2)
> kvm_emulate_insn: 42000:0:0f 0b (0x2) failed
> kvm_inj_exception: #UD (0x0)
> kvm_entry: vcpu 0
> kvm_exit: reason TASK_SWITCH rip 0x0 info 40000058 0
> kvm_emulate_insn: 42000:0:0f 0b (0x2)
> kvm_emulate_insn: 42000:0:0f 0b (0x2) failed
> kvm_inj_exception: #UD (0x0)
> ......................
> 
> It appears that the task-switch emulation updates rflags (and vm86 
> flag) only after the segments are loaded, causing vmx->emulation_required 
> to be set, when in fact invalid guest state emulation is not needed.
> 
> This patch fixes it by updating vmx->emulation_required after the 
> rflags (and vm86 flag) is updated in task-switch emulation.
> 
> Thanks Radim for moving the update to vmx__set_flags and adding Paolo's 
> suggestion for the check.
> 
> Suggested-by: Nadav Amit <nadav.amit@gmail.com>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: Radim Krčmář <rkrcmar@redhat.com>
> Cc: Nadav Amit <nadav.amit@gmail.com>
> Signed-off-by: Wanpeng Li <wanpeng.li@hotmail.com>
> ---
> diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
>  static void vmx_set_rflags(struct kvm_vcpu *vcpu, unsigned long rflags)
>  {
> +	unsigned long old_rflags = vmx_get_rflags(vcpu);
> +	unsigned long save_rflags = rflags;
> +
>  	__set_bit(VCPU_EXREG_RFLAGS, (ulong *)&vcpu->arch.regs_avail);
>  	to_vmx(vcpu)->rflags = rflags;
>  	if (to_vmx(vcpu)->rmode.vm86_active) {
> @@ -2370,6 +2378,9 @@ static void vmx_set_rflags(struct kvm_vcpu *vcpu, unsigned long rflags)
>  		rflags |= X86_EFLAGS_IOPL | X86_EFLAGS_VM;
>  	}
>  	vmcs_writel(GUEST_RFLAGS, rflags);
> +
> +	if ((old_rflags ^ save_rflags) & X86_EFLAGS_VM)

Looks good, thanks to both.

The desired rflags are saved in to_vmx(vcpu)->rflags, so we don't need
the temporary variable -- would using that or vmx_get_rflags(vcpu)
generate worse code?

Thread

[PATCH v2] KVM: VMX: Fix invalid guest state detection after task-switch emulation Wanpeng Li <kernellwp@gmail.com> - 2017-07-20 01:50 +0200
  Re: [PATCH v2] KVM: VMX: Fix invalid guest state detection after  task-switch emulation Radim Krčmář <rkrcmar@redhat.com> - 2017-07-20 10:00 +0200
    Re: [PATCH v2] KVM: VMX: Fix invalid guest state detection after  task-switch emulation Wanpeng Li <kernellwp@gmail.com> - 2017-07-20 10:10 +0200

csiph-web