Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1692524
| From | Oliver Hartkopp <socketcan@hartkopp.net> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 1/4] can: dev: Add support for limiting configured bitrate |
| Date | 2017-07-20 09:50 +0200 |
| Message-ID | <u5enD-4a1-3@gated-at.bofh.it> (permalink) |
| References | <u56Jr-7ff-13@gated-at.bofh.it> <u56Js-7ff-25@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Hi Franklin,
On 07/20/2017 01:36 AM, Franklin S Cooper Jr wrote:
> +#ifdef CONFIG_OF
> +void of_transceiver_is_fixed(struct net_device *dev)
> +{
(..)
> +}
> +EXPORT_SYMBOL(of_transceiver_is_fixed);
> +#endif
I'm not sure about the naming here.
As this is a CAN transceiver related option it should be named accordingly:
E.g.
can_transceiver_is_fixed
of_can_transceiver_is_fixed
...
Especially as it is defined in include/linux/can/dev.h
Regards,
Oliver
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/4] can: Add new binding to limit bit rate used Franklin S Cooper Jr <fcooper@ti.com> - 2017-07-20 01:40 +0200
[PATCH 3/4] can: m_can: Update documentation to mention new fixed transceiver binding Franklin S Cooper Jr <fcooper@ti.com> - 2017-07-20 01:40 +0200
Re: [PATCH 3/4] can: m_can: Update documentation to mention new fixed transceiver binding Rob Herring <robh@kernel.org> - 2017-07-24 22:00 +0200
[PATCH 1/4] can: dev: Add support for limiting configured bitrate Franklin S Cooper Jr <fcooper@ti.com> - 2017-07-20 01:40 +0200
Re: [PATCH 1/4] can: dev: Add support for limiting configured bitrate Oliver Hartkopp <socketcan@hartkopp.net> - 2017-07-20 09:50 +0200
Re: [PATCH 1/4] can: dev: Add support for limiting configured bitrate Franklin S Cooper Jr <fcooper@ti.com> - 2017-07-20 18:00 +0200
Re: [PATCH 1/4] can: dev: Add support for limiting configured bitrate Kurt Van Dijck <dev.kurt@vandijck-laurijssen.be> - 2017-07-26 22:30 +0200
Re: [PATCH 1/4] can: dev: Add support for limiting configured bitrate Franklin S Cooper Jr <fcooper@ti.com> - 2017-07-27 03:50 +0200
Re: [PATCH 1/4] can: dev: Add support for limiting configured bitrate Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2017-07-20 12:00 +0200
Re: [PATCH 1/4] can: dev: Add support for limiting configured bitrate Franklin S Cooper Jr <fcooper@ti.com> - 2017-07-20 18:10 +0200
[PATCH 4/4] can: m_can: Add call to of_transceiver_is_fixed Franklin S Cooper Jr <fcooper@ti.com> - 2017-07-20 01:40 +0200
csiph-web