[PATCH V1 08/12] spmi: pmic-arb: use irq_chip callback to set spmi irq wakeup capability

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Kiran Gunda <kgunda@codeaurora.org>
Newsgroups	linux.kernel
Subject	[PATCH V1 08/12] spmi: pmic-arb: use irq_chip callback to set spmi irq wakeup capability
Date	Thu, 20 Jul 2017 09:40:06 +0200
Message-ID	<u5ee2-46l-99@gated-at.bofh.it> (permalink)
References	<u5edY-46l-13@gated-at.bofh.it>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1500535979; bh=fj1y66ImuKXqRiug1SvEbfOGysAku4wkadkW4vjPlu4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=l7LW54TOzDXPfyCXc/dhJ5pUDPhFDIbdQVf8CnF6UFYKZP8I/7peOE7CjgP68ggvn 5poTl+40qLL5BAip8Yw1KHdk7yfm4bXZp+8FCEJ/a1USSsRasiOUVEi0eZ8saLEcep 7ill3KkJvHopgtlYF1zx45FzGNvHyT7Ot4x764+k=
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1500535978; bh=fj1y66ImuKXqRiug1SvEbfOGysAku4wkadkW4vjPlu4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=nMkSVd/bNphAaQu/+Sn/+eh535oIfSIwE5neeFOYZb8qfefKo1eWManPTFctIRjPV 5dOiSTAxZq6v5FFyrlLLZSRD6DLbSgdYJKYPb4Dz6pZn6N56DaOXQyFAY3yH+sK5x7 qU+b4Jn3PiDfurkHnQsOZ6xDV+yaGpbKn9juieb8=
Dmarc-Filter	OpenDMARC Filter v1.3.2 smtp.codeaurora.org A0D346072E
Authentication-Results	pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org
Authentication-Results	pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kgunda@codeaurora.org
X-Mailer	git-send-email 1.9.1
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	54
Organization	linux.* mail to news gateway
X-Original-Cc	linux-arm-msm@vger.kernel.org
X-Original-Date	Thu, 20 Jul 2017 13:01:46 +0530
X-Original-Message-ID	<1500535910-28705-9-git-send-email-kgunda@codeaurora.org>
X-Original-References	<1500535910-28705-1-git-send-email-kgunda@codeaurora.org>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1692514

Show key headers only | View raw

Currently the driver sets the pmic arbiter core interrupt as wakeup capable
irrespective of the child irqs which causes the system to wakeup
unnecessarily. To fix this, set the core interrupt as wakeup capable
only if any of the child irqs request for it. Do this by marking it as
wakeup capable in the irq_set_wake callback.

Signed-off-by: Kiran Gunda <kgunda@codeaurora.org>
Reviewed-by: Stephen Boyd <sboyd@codeaurora.org>
---
 drivers/spmi/spmi-pmic-arb.c | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)

diff --git a/drivers/spmi/spmi-pmic-arb.c b/drivers/spmi/spmi-pmic-arb.c
index fed2883a..e8c08c0 100644
--- a/drivers/spmi/spmi-pmic-arb.c
+++ b/drivers/spmi/spmi-pmic-arb.c
@@ -622,6 +622,13 @@ static int qpnpint_irq_set_type(struct irq_data *d, unsigned int flow_type)
 	return 0;
 }
 
+static int qpnpint_irq_set_wake(struct irq_data *d, unsigned int on)
+{
+	struct spmi_pmic_arb *pmic_arb = irq_data_get_irq_chip_data(d);
+
+	return irq_set_irq_wake(pmic_arb->irq, on);
+}
+
 static int qpnpint_get_irqchip_state(struct irq_data *d,
 				     enum irqchip_irq_state which,
 				     bool *state)
@@ -644,9 +651,9 @@ static int qpnpint_get_irqchip_state(struct irq_data *d,
 	.irq_mask	= qpnpint_irq_mask,
 	.irq_unmask	= qpnpint_irq_unmask,
 	.irq_set_type	= qpnpint_irq_set_type,
+	.irq_set_wake	= qpnpint_irq_set_wake,
 	.irq_get_irqchip_state	= qpnpint_get_irqchip_state,
-	.flags		= IRQCHIP_MASK_ON_SUSPEND
-			| IRQCHIP_SKIP_SET_WAKE,
+	.flags		= IRQCHIP_MASK_ON_SUSPEND,
 };
 
 static int qpnpint_irq_domain_dt_translate(struct irq_domain *d,
@@ -1068,8 +1075,6 @@ static int spmi_pmic_arb_probe(struct platform_device *pdev)
 
 	irq_set_chained_handler_and_data(pmic_arb->irq, pmic_arb_chained_irq,
 					pmic_arb);
-	enable_irq_wake(pmic_arb->irq);
-
 	err = spmi_controller_add(ctrl);
 	if (err)
 		goto err_domain_remove;
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH V1 08/12] spmi: pmic-arb: use irq_chip callback to set spmi irq wakeup capability Kiran Gunda <kgunda@codeaurora.org> - 2017-07-20 09:40 +0200

csiph-web