Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1692512
| Path | csiph.com!news.redatomik.org!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | Okash Khawaja <okash.khawaja@gmail.com> |
| Newsgroups | linux.kernel |
| Subject | [patch v3 2/3] staging: speakup: use tty_kopen and tty_kclose |
| Date | Thu, 20 Jul 2017 09:40:06 +0200 |
| Message-ID | <u5ee2-46l-89@gated-at.bofh.it> (permalink) |
| References | <u4BcC-35L-19@gated-at.bofh.it> <u5e4h-41p-3@gated-at.bofh.it> |
| Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=message-id:user-agent:date:from:to:cc:subject:references :mime-version:content-disposition; bh=ol6fy7DGSOb9jmdJ9I8twuFsXZVkDdJl4jBcGZn/Gmo=; b=Jwc/tBqWE+OaOl/0G0aKonLGovzJnRi39BhbMsa4HAXjuQKqWwOOnqgc+WoioL+5pf /0SsjqX3265TNOuGW0IcWZjvYNJTNy3AntupeiYlSHKA1DXtXPkGCzD4tkDjJdc7PH1b rbh41EifO+9lu4x77nqH1JBJO5pH7+Tg1m0KyYgOuAeaLAGxkQau2+T910QBrUuBGdkI jleq39cEe0jS2WBd9+FAvjDPqQ5IYaGUDwyv7BQRgAjCztdNJ9deUhlsvhfZDIyToM7x zjtHPmB3lonOELdzY3Cv9PGGmeqILXFp9JqzyT/GNYFiNnVrN2u8AHFywA+TJavzkZf8 DWwQ== |
| X-Google-Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:user-agent:date:from:to:cc:subject :references:mime-version:content-disposition; bh=ol6fy7DGSOb9jmdJ9I8twuFsXZVkDdJl4jBcGZn/Gmo=; b=haypRryn+nz3LnRNUjG4rOP4FUWPUmZQLSeJ0zWpOuLfiR5Bv24kxhzVTFZ5aIjbx1 iay2qr1b2+0bxAZ1wpdt5oO3E9Hrz9Z0Vj1P7m7bkJ4teinIL9xZLTkqvL0ufB7d472d DKhCp1t6Qem+IMKaSFVpjoRZtNbJizHnd2cIlehtQo4gZHL/CcBlHx8qPnUgphmeWPQH dGQ6t0lKAg19fv3l39pztYilPhgHot2yWkpTOwpt3zekJoElnV4ITH7H/SO12oP9dERq KP0YX0llQArgjILY3nLaaJoZ1GjigCY4gkfm0uOacLl1cqNzvZYDDrRFDsN8JH2vMow8 HIHQ== |
| X-Gm-Message-State | AIVw111tiBvIHjoAUy8tT/vgGlQKP1Ps9cC8498gquNqQYHEBjAquWPC 9zdAa0ZQ8RQakw== |
| X-Received | by 10.223.155.133 with SMTP id d5mr6367886wrc.196.1500535766192; Thu, 20 Jul 2017 00:29:26 -0700 (PDT) |
| User-Agent | quilt/0.65 |
| MIME-Version | 1.0 |
| Content-Type | text/plain; charset=ISO-8859-15 |
| Content-Disposition | inline; filename=20_use_tty_kopen |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 29 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | William Hubbs <w.d.hubbs@gmail.com>, Chris Brannon <chris@the-brannons.com>, Kirk Reiser <kirk@reisers.ca>, speakup@linux-speakup.org, devel@driverdev.osuosl.org, Okash Khawaja <okash.khawaja@gmail.com> |
| X-Original-Date | Thu, 20 Jul 2017 08:22:37 +0100 |
| X-Original-Message-ID | <20170720072922.883699761@gmail.com> |
| X-Original-References | <20170718144931.0f6c9634@alans-desktop> <20170720072235.186761910@gmail.com> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1692512 |
Show key headers only | View raw
This patch replaces call to tty_open_by_driver with a tty_kopen and uses tty_kclose instead of tty_release_struct to close it. Signed-off-by: Okash Khawaja <okash.khawaja@gmail.com> --- drivers/staging/speakup/spk_ttyio.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/drivers/staging/speakup/spk_ttyio.c +++ b/drivers/staging/speakup/spk_ttyio.c @@ -158,7 +158,7 @@ static int spk_ttyio_initialise_ldisc(st if (ret) return ret; - tty = tty_open_by_driver(dev, NULL, NULL); + tty = tty_kopen(dev); if (IS_ERR(tty)) return PTR_ERR(tty); @@ -308,7 +308,7 @@ void spk_ttyio_release(void) tty_ldisc_flush(speakup_tty); tty_unlock(speakup_tty); - tty_release_struct(speakup_tty, speakup_tty->index); + tty_kclose(speakup_tty); } EXPORT_SYMBOL_GPL(spk_ttyio_release);
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
Re: [patch 0/3] Re: tty contention resulting from tty_open_by_device export Okash Khawaja <okash.khawaja@gmail.com> - 2017-07-18 13:40 +0200
Re: [patch 0/3] Re: tty contention resulting from tty_open_by_device export Dan Carpenter <dan.carpenter@oracle.com> - 2017-07-18 14:30 +0200
Re: [patch 0/3] Re: tty contention resulting from tty_open_by_device export Okash Khawaja <okash.khawaja@gmail.com> - 2017-07-18 21:30 +0200
Re: [patch 0/3] Re: tty contention resulting from tty_open_by_device export Alan Cox <gnomes@lxorguk.ukuu.org.uk> - 2017-07-18 16:00 +0200
[patch v3 3/3] tty: undo export of tty_open_by_driver Okash Khawaja <okash.khawaja@gmail.com> - 2017-07-20 09:30 +0200
[patch v3 1/3] tty: resolve tty contention between kernel and user space Okash Khawaja <okash.khawaja@gmail.com> - 2017-07-20 09:30 +0200
[patch v3 0/3] tty contention resulting from tty_open_by_driver export Okash Khawaja <okash.khawaja@gmail.com> - 2017-07-20 09:30 +0200
[patch v3 2/3] staging: speakup: use tty_kopen and tty_kclose Okash Khawaja <okash.khawaja@gmail.com> - 2017-07-20 09:40 +0200
csiph-web