[PATCH V1 12/12] spmi: pmic-arb: Remove checking opc value not less than 0

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Kiran Gunda <kgunda@codeaurora.org>
Newsgroups	linux.kernel
Subject	[PATCH V1 12/12] spmi: pmic-arb: Remove checking opc value not less than 0
Date	Thu, 20 Jul 2017 09:40:05 +0200
Message-ID	<u5ee1-46l-87@gated-at.bofh.it> (permalink)
References	<u5edY-46l-13@gated-at.bofh.it>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1500535998; bh=rzuhWAlX0FwKd5qul9w+PT842OsUXmA1iAUFRVSr1uQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=nJ7yz06fs1lBcPiV96sFBC2Urq7P+k57+YhsGzmQidP6eB94PRUluFV14PUdoOnp8 t8tZW4UVeFQLusyVfkiDdclTjIo4gsnO4GK83WmfAIzMvkKN/3ca8i5jg7zDrK7gB6 lioZFqFMU6lJRCB4/XNRJzmToEBnlC0lwPYDXaEc=
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1500535998; bh=rzuhWAlX0FwKd5qul9w+PT842OsUXmA1iAUFRVSr1uQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=nJ7yz06fs1lBcPiV96sFBC2Urq7P+k57+YhsGzmQidP6eB94PRUluFV14PUdoOnp8 t8tZW4UVeFQLusyVfkiDdclTjIo4gsnO4GK83WmfAIzMvkKN/3ca8i5jg7zDrK7gB6 lioZFqFMU6lJRCB4/XNRJzmToEBnlC0lwPYDXaEc=
Dmarc-Filter	OpenDMARC Filter v1.3.2 smtp.codeaurora.org 1A3BF6072E
Authentication-Results	pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org
Authentication-Results	pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kgunda@codeaurora.org
X-Mailer	git-send-email 1.9.1
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	37
Organization	linux.* mail to news gateway
X-Original-Cc	linux-arm-msm@vger.kernel.org, Fenglin Wu <fenglinw@codeaurora.org>
X-Original-Date	Thu, 20 Jul 2017 13:01:50 +0530
X-Original-Message-ID	<1500535910-28705-13-git-send-email-kgunda@codeaurora.org>
X-Original-References	<1500535910-28705-1-git-send-email-kgunda@codeaurora.org>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1692509

Show key headers only | View raw

From: Fenglin Wu <fenglinw@codeaurora.org>

The opc parameter in pmic_arb_write_cmd() function is defined with type
u8 and it's always greater than or equal to 0. Checking that it's not
less than 0 is redundant and it can cause a forbidden warning during
compilation. Remove the check.

Signed-off-by: Fenglin Wu <fenglinw@codeaurora.org>
Signed-off-by: Kiran Gunda <kgunda@codeaurora.org>
Reviewed-by: Stephen Boyd <sboyd@codeaurora.org>
---
 drivers/spmi/spmi-pmic-arb.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/spmi/spmi-pmic-arb.c b/drivers/spmi/spmi-pmic-arb.c
index 01559d7..8ab3f6d 100644
--- a/drivers/spmi/spmi-pmic-arb.c
+++ b/drivers/spmi/spmi-pmic-arb.c
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2012-2015, The Linux Foundation. All rights reserved.
+ * Copyright (c) 2012-2015, 2017, The Linux Foundation. All rights reserved.
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 2 and
@@ -419,7 +419,7 @@ static int pmic_arb_write_cmd(struct spmi_controller *ctrl, u8 opc, u8 sid,
 	/* Check the opcode */
 	if (opc >= 0x40 && opc <= 0x5F)
 		opc = PMIC_ARB_OP_WRITE;
-	else if (opc >= 0x00 && opc <= 0x0F)
+	else if (opc <= 0x0F)
 		opc = PMIC_ARB_OP_EXT_WRITE;
 	else if (opc >= 0x30 && opc <= 0x37)
 		opc = PMIC_ARB_OP_EXT_WRITEL;
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH V1 12/12] spmi: pmic-arb: Remove checking opc value not less than 0 Kiran Gunda <kgunda@codeaurora.org> - 2017-07-20 09:40 +0200

csiph-web