[PATCH net] net: ethernet: mediatek: avoid potential invalid memory access

From	<sean.wang@mediatek.com>
Newsgroups	linux.kernel
Subject	[PATCH net] net: ethernet: mediatek: avoid potential invalid memory access
Date	2017-07-20 09:00 +0200
Message-ID	<u5dBf-3AP-5@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Sean Wang <sean.wang@mediatek.com>

Potential dangerous invalid memory might be accessed if invalid mac value
reflected from the forward port field in rxd4 caused by possible potential
hardware defects. So added a simple sanity checker to avoid the kind of
situation happening.

Signed-off-by: Sean Wang <sean.wang@mediatek.com>
---
 drivers/net/ethernet/mediatek/mtk_eth_soc.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
index c1dc08c..8175433 100644
--- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c
+++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
@@ -999,6 +999,12 @@ static int mtk_poll_rx(struct napi_struct *napi, int budget,
 		      RX_DMA_FPORT_MASK;
 		mac--;
 
+		if (unlikely(mac < 0 || mac >= MTK_MAC_COUNT ||
+			     !eth->netdev[mac])) {
+			netdev->stats.rx_dropped++;
+			goto release_desc;
+		}
+
 		netdev = eth->netdev[mac];
 
 		if (unlikely(test_bit(MTK_RESETTING, &eth->state)))
-- 
2.7.4

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH net] net: ethernet: mediatek: avoid potential invalid memory access <sean.wang@mediatek.com> - 2017-07-20 09:00 +0200
  Re: [PATCH net] net: ethernet: mediatek: avoid potential invalid  memory access John Crispin <john@phrozen.org> - 2017-07-20 09:10 +0200

csiph-web