Re: [PATCH 5/5] vfio: platform: reset: Add Broadcom FlexRM reset module

From	Anup Patel <anup.patel@broadcom.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 5/5] vfio: platform: reset: Add Broadcom FlexRM reset module
Date	2017-07-20 06:10 +0200
Message-ID	<u5aWK-1Uo-7@gated-at.bofh.it> (permalink)
References	<u4TCy-6D1-9@gated-at.bofh.it> <u4TCy-6D1-11@gated-at.bofh.it> <u50um-2TW-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Jul 19, 2017 at 10:20 PM, Scott Branden
<scott.branden@broadcom.com> wrote:
> Hi Anup,
>
> NAK - as indicated in internal review please use unmodified Broadcom legal
> header in its own comment block.

I had addressed your internal review comments and used
standard GLPv2 header (also present in other drivers). The
only part I missed was to keep additional comments as
separate comment block (which you had not mentioned
in internal review).

Anyways, I will update the comment header but I think
using "NAK" in such situation is a bit over-kill

Regards,
Anup

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 5/5] vfio: platform: reset: Add Broadcom FlexRM reset module Anup Patel <anup.patel@broadcom.com> - 2017-07-19 11:40 +0200
  Re: [PATCH 5/5] vfio: platform: reset: Add Broadcom FlexRM reset  module Scott Branden <scott.branden@broadcom.com> - 2017-07-19 19:00 +0200
    Re: [PATCH 5/5] vfio: platform: reset: Add Broadcom FlexRM reset module Anup Patel <anup.patel@broadcom.com> - 2017-07-20 06:10 +0200

csiph-web