Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1694114

Re: [PATCH] EDAC: remove unnecessary static in edac_fake_inject_write()

From Julia Lawall <julia.lawall@lip6.fr>
Newsgroups linux.kernel
Subject Re: [PATCH] EDAC: remove unnecessary static in edac_fake_inject_write()
Date 2017-07-22 08:40 +0200
Message-ID <u5WeZ-6TP-3@gated-at.bofh.it> (permalink)
References <tZEb7-5V4-9@gated-at.bofh.it> <u49T4-2FF-21@gated-at.bofh.it> <u5Mpj-Qz-3@gated-at.bofh.it> <u5WeZ-6TP-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Sat, 22 Jul 2017, Borislav Petkov wrote:

> On Fri, Jul 21, 2017 at 10:08:12PM +0200, Julia Lawall wrote:
> > Someone pointed out that the rule is probably not OK when the address of
> > the static variable is taken, because then it is likely being used as
> > permanent storage.
>
> Makes sense to me.
>
> > An improved rule is:
>
> Do you think it is worth having it in scripts/coccinelle/ ?

Sure.  Now that it has been a bit more sanity checked.

> I don't think Gustavo would mind putting it there :)

OK, I will check with him.

julia

>
> Thanks.
>
> --
> Regards/Gruss,
>     Boris.
>
> ECO tip #101: Trim your mails when you reply.
> --
>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] EDAC: remove unnecessary static in  edac_fake_inject_write() Julia Lawall <julia.lawall@lip6.fr> - 2017-07-21 22:10 +0200
  Re: [PATCH] EDAC: remove unnecessary static in  edac_fake_inject_write() Borislav Petkov <bp@alien8.de> - 2017-07-22 08:40 +0200
    Re: [PATCH] EDAC: remove unnecessary static in  edac_fake_inject_write() Julia Lawall <julia.lawall@lip6.fr> - 2017-07-22 08:40 +0200
    Re: [PATCH] EDAC: remove unnecessary static in  edac_fake_inject_write() "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-07-22 18:30 +0200
      Re: [PATCH] EDAC: remove unnecessary static in  edac_fake_inject_write() "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-07-23 04:40 +0200
        Re: [PATCH] EDAC: remove unnecessary static in  edac_fake_inject_write() Julia Lawall <julia.lawall@lip6.fr> - 2017-07-23 07:10 +0200
          Re: [PATCH] EDAC: remove unnecessary static in  edac_fake_inject_write() "Gustavo A. R. Silva" <gustavo@embeddedor.com> - 2017-07-23 07:50 +0200
            Re: [PATCH] EDAC: remove unnecessary static in  edac_fake_inject_write() Julia Lawall <julia.lawall@lip6.fr> - 2017-07-23 08:00 +0200
              Re: [PATCH] EDAC: remove unnecessary static in  edac_fake_inject_write() "Gustavo A. R. Silva" <gustavo@embeddedor.com> - 2017-07-23 08:30 +0200
                Re: [PATCH] EDAC: remove unnecessary static in  edac_fake_inject_write() Borislav Petkov <bp@alien8.de> - 2017-07-24 12:40 +0200

csiph-web