Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1693971

Re: [RFC 1/2] net-next: add a dma_desc element to struct skb_shared_info

Show all headers | View raw

John Crispin <john@phrozen.org> wrote:
> When the flow offloading engine forwards a packet to the DMA it will send
> additional info to the sw path. this includes
> * physical switch port
> * internal flow hash - this is required to populate the correct flow table
> entry
> * ppe state - this indicates what state the PPEs internal table is in for
> the flow
> * the reason why the packet was forwarde - these are things like bind,
> unbind, timed out, ...
> 
> once the flow table offloading patches are ready and upstream, the netfilter
> layer will see the SKB and pass it o to the flow table offloading code,

If this is about conntrack offloading, then I prefer if this is done
without changing any core network structure.

What about adding a new conntrack extension to hold whatever info
you need, and then allocate a conntrack entry in the driver?

This would obviously need core changes in conntrack (such as allowing
calls into conntrack from drivers without hard module dependencies,
and a thorough check if this causes backwards problems (e.g.
right now a "-m conntrack" check in the raw table can only succeed for
packets from lo interface).

But I think that could be worked around, esp. if we assume that we
won't see such entries a lot (assuming sw is slowpath and hw handles
most packets).

Thanks,
Florian

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[RFC 0/2] net-next: hw flow offloading John Crispin <john@phrozen.org> - 2017-07-21 17:30 +0200
  [RFC 2/2] net-next: mediatek: populate the shared John Crispin <john@phrozen.org> - 2017-07-21 17:30 +0200
  [RFC 1/2] net-next: add a dma_desc element to struct skb_shared_info John Crispin <john@phrozen.org> - 2017-07-21 17:30 +0200
    Re: [RFC 1/2] net-next: add a dma_desc element to struct  skb_shared_info Paolo Abeni <pabeni@redhat.com> - 2017-07-21 18:00 +0200
      Re: [RFC 1/2] net-next: add a dma_desc element to struct  skb_shared_info John Crispin <john@phrozen.org> - 2017-07-21 19:10 +0200
        Re: [RFC 1/2] net-next: add a dma_desc element to struct  skb_shared_info David Miller <davem@davemloft.net> - 2017-07-21 21:30 +0200
        Re: [RFC 1/2] net-next: add a dma_desc element to struct  skb_shared_info Florian Westphal <fw@strlen.de> - 2017-07-21 22:40 +0200

csiph-web