Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1693633

Re: [PATCH] pci: add missing __iomem cast

Show all headers | View raw

Hi Christoph,

Looking deep into to this, i think there is no need to use phy_to_virts since pdev->rom is already a physical address.
That's what pci_platform_rom should return, right?!

I'll probably send a new patch removing the usage of phys_to_virt.

Regards,
C.Palminha

On 20-07-2017 09:07, Christoph Hellwig wrote:
> On Wed, Jul 19, 2017 at 01:05:35PM +0100, Carlos Palminha wrote:
>> Add missing __iomem annotation to fix sparse warning:
>> - incorrect type in return expression (different address spaces)
> 
> How is this going to shut up sparse without a __force?
> 
> And once you add the __force please also add a comment explaining
> why it's safe.
> 

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] pci: add missing __iomem cast Carlos Palminha <CARLOS.PALMINHA@synopsys.com> - 2017-07-19 14:10 +0200
  Re: [PATCH] pci: add missing __iomem cast Christoph Hellwig <hch@infradead.org> - 2017-07-20 10:10 +0200
    Re: [PATCH] pci: add missing __iomem cast Carlos Palminha <CARLOS.PALMINHA@synopsys.com> - 2017-07-21 13:40 +0200

csiph-web