Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1693640

Problematic culture around Signed-off-by

Show all headers | View raw

Hi folks,

I've been away from kernel development for a bit, but I've returned and
I'm troubled by what seems to be an entrenched and widespread (IMO)
misuse of the "Signed-off-by:" in commits.

I've now either been asked to sign off RFC quality patches "because its
quicker" on more than one occasion in the last week or so, and I've seen
others signing off code which clearly has no hope of going anywhere near
the kernel. (eg. // commented out lines)

I was of the impression that Signed-off-by: was intended to be used on
essentially *finished* commits, indicating both readiness for inclusion
upstream and ones ownership of the copyright.

Even if the intent is *purely* a copyright isue, Signing off
*everything* surely makes it far too easy for people to get junk into
the kernel.

I've actually been deliberately NOT signing off my code because I *DONT*
want it surreptitiously applied with my name on it unless its 100% spot on.

WTH is going on? How can we fix this?

Is Signed-off-by: a lost cause for code quality?

Do we need to add a

Ready-for-mainline: {yes,no} field as well?

Have I just missed something? Maybe I'm just in a minority here? Whats
going on?

-Ian

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Problematic culture around Signed-off-by Ian Molton <spyro2@gmail.com> - 2017-07-21 13:50 +0200
  Re: Problematic culture around Signed-off-by Pavel Machek <pavel@ucw.cz> - 2017-07-30 21:00 +0200

csiph-web