Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1692232
| From | Dave Jiang <dave.jiang@intel.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] dmaengine: ioatdma: Fix error handling path in 'ioat_dma_self_test()' |
| Date | 2017-07-20 00:30 +0200 |
| Message-ID | <u55DH-6xU-7@gated-at.bofh.it> (permalink) |
| References | <u55u2-6uk-7@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 07/19/2017 03:16 PM, Christophe JAILLET wrote:
> If the 'memcmp' fails, free allocated resources as done in all other
> error handling paths.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Good catch! Thanks.
Signed-off-by: Dave Jiang <dave.jiang@intel.com>
> ---
> Please review carefully, this patch looks "too obvious" to me!
> ---
> drivers/dma/ioat/init.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/ioat/init.c b/drivers/dma/ioat/init.c
> index ed8ed1192775..948fc1f8fb5c 100644
> --- a/drivers/dma/ioat/init.c
> +++ b/drivers/dma/ioat/init.c
> @@ -390,7 +390,7 @@ static int ioat_dma_self_test(struct ioatdma_device *ioat_dma)
> if (memcmp(src, dest, IOAT_TEST_SIZE)) {
> dev_err(dev, "Self-test copy failed compare, disabling\n");
> err = -ENODEV;
> - goto free_resources;
> + goto unmap_dma;
> }
>
> unmap_dma:
>
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] dmaengine: ioatdma: Fix error handling path in 'ioat_dma_self_test()' Christophe JAILLET <christophe.jaillet@wanadoo.fr> - 2017-07-20 00:20 +0200
Re: [PATCH] dmaengine: ioatdma: Fix error handling path in 'ioat_dma_self_test()' Dave Jiang <dave.jiang@intel.com> - 2017-07-20 00:30 +0200
Re: [PATCH] dmaengine: ioatdma: Fix error handling path in 'ioat_dma_self_test()' Vinod Koul <vinod.koul@intel.com> - 2017-07-21 08:30 +0200
Re: [PATCH] dmaengine: ioatdma: Fix error handling path in 'ioat_dma_self_test()' "Jiang, Dave" <dave.jiang@intel.com> - 2017-07-21 08:50 +0200
Re: [PATCH] dmaengine: ioatdma: Fix error handling path in 'ioat_dma_self_test()' walter harms <wharms@bfs.de> - 2017-07-20 09:30 +0200
Re: [PATCH] dmaengine: ioatdma: Fix error handling path in 'ioat_dma_self_test()' Dave Jiang <dave.jiang@intel.com> - 2017-07-20 19:00 +0200
Re: [PATCH] dmaengine: ioatdma: Fix error handling path in 'ioat_dma_self_test()' walter harms <wharms@bfs.de> - 2017-07-21 09:30 +0200
Re: [PATCH] dmaengine: ioatdma: Fix error handling path in 'ioat_dma_self_test()' Julia Lawall <julia.lawall@lip6.fr> - 2017-07-21 09:30 +0200
Re: [PATCH] dmaengine: ioatdma: Fix error handling path in 'ioat_dma_self_test()' Dan Carpenter <dan.carpenter@oracle.com> - 2017-07-21 11:40 +0200
Re: [PATCH] dmaengine: ioatdma: Fix error handling path in 'ioat_dma_self_test()' Vinod Koul <vinod.koul@intel.com> - 2017-07-21 10:00 +0200
Re: [PATCH] dmaengine: ioatdma: Fix error handling path in 'ioat_dma_self_test()' Dave Jiang <dave.jiang@intel.com> - 2017-07-21 19:00 +0200
csiph-web