Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1692222

[PATCH] crypto: ixp4xx - Fix error handling path in 'aead_perform()'

Show all headers | View raw

In commit 0f987e25cb8a, the source processing has been moved in front of
the destination processing, but the error handling path has not been
modified accordingly.
Free resources in the correct order to avoid some leaks.

Fixes: 0f987e25cb8a ("crypto: ixp4xx - Fix false lastlen uninitialised warning")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
 drivers/crypto/ixp4xx_crypto.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/crypto/ixp4xx_crypto.c b/drivers/crypto/ixp4xx_crypto.c
index 427cbe012729..1ccbe15b5f16 100644
--- a/drivers/crypto/ixp4xx_crypto.c
+++ b/drivers/crypto/ixp4xx_crypto.c
@@ -1088,10 +1088,10 @@ static int aead_perform(struct aead_request *req, int encrypt,
 	BUG_ON(qmgr_stat_overflow(SEND_QID));
 	return -EINPROGRESS;
 
-free_buf_src:
-	free_buf_chain(dev, req_ctx->src, crypt->src_buf);
 free_buf_dst:
 	free_buf_chain(dev, req_ctx->dst, crypt->dst_buf);
+free_buf_src:
+	free_buf_chain(dev, req_ctx->src, crypt->src_buf);
 	crypt->ctl_flags = CTL_FLAG_UNUSED;
 	return -ENOMEM;
 }
-- 
2.11.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] crypto: ixp4xx - Fix error handling path in 'aead_perform()' Christophe JAILLET <christophe.jaillet@wanadoo.fr> - 2017-07-19 23:50 +0200
  Re: [PATCH] crypto: ixp4xx - Fix error handling path in 'aead_perform()' Arnd Bergmann <arnd@arndb.de> - 2017-07-20 09:40 +0200
    Re: [PATCH] crypto: ixp4xx - Fix error handling path in 'aead_perform()' Arnd Bergmann <arnd@arndb.de> - 2017-07-20 17:10 +0200
      Re: [PATCH] crypto: ixp4xx - Fix error handling path in 'aead_perform()' Arnd Bergmann <arnd@arndb.de> - 2017-07-20 17:20 +0200

csiph-web