Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1692106

RE: [PATCH] netvsc: Remove redundant use of ipv6_hdr()

Show all headers | View raw

> -----Original Message-----
> From: Mohammed Gamal [mailto:mgamal@redhat.com]
> Sent: Wednesday, July 19, 2017 1:48 PM
> To: Stephen Hemminger <stephen@networkplumber.org>
> Cc: KY Srinivasan <kys@microsoft.com>; Haiyang Zhang
> <haiyangz@microsoft.com>; Stephen Hemminger <sthemmin@microsoft.com>;
> otubo@redhat.com; linux-kernel@vger.kernel.org;
> devel@linuxdriverproject.org; vkuznets@redhat.com
> Subject: Re: [PATCH] netvsc: Remove redundant use of ipv6_hdr()
> 
> 
> 
> ----- Original Message -----
> > On Wed, 19 Jul 2017 15:19:28 +0200
> > Mohammed Gamal <mgamal@redhat.com> wrote:
> >
> > > This condition already uses an object of type ipv6hdr in the line
> above.
> > > Use the object directly instead of calling ipv6_hdr
> > >
> > > Signed-off-by: Mohammed Gamal <mgamal@redhat.com>
> > > ---
> > >  drivers/net/hyperv/netvsc_drv.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/net/hyperv/netvsc_drv.c
> > > b/drivers/net/hyperv/netvsc_drv.c
> > > index 63c98bb..06d591c 100644
> > > --- a/drivers/net/hyperv/netvsc_drv.c
> > > +++ b/drivers/net/hyperv/netvsc_drv.c
> > > @@ -339,7 +339,7 @@ static u32 net_checksum_info(struct sk_buff *skb)
> > >
> > >  		if (ip6->nexthdr == IPPROTO_TCP)
> > >  			return TRANSPORT_INFO_IPV6_TCP;
> > > -		else if (ipv6_hdr(skb)->nexthdr == IPPROTO_UDP)
> > > +		else if (ip6->nexthdr == IPPROTO_UDP)
> > >  			return TRANSPORT_INFO_IPV6_UDP;
> > >  	}
> > >
> >
> > Patch looks fine.
> > Network patches go through netdev@vger.kernel.org not linux driver
> mailing
> > list.
> > I will add it to my next patch of patches that are going to netdev for
> > net-next.
> >
> Thanks for the heads up. Will take that into consideration next time.
> 
> It's worth pointing out that MAINTAINERS points that files under
> drivers/net/hyperv are to be sent to devel@linuxdriverproject.org.
> Perhaps that should be updated.

I will update devel@linuxdriverproject.org in MAINTAINERS to the new
mailing list name of the Linux driver project.

Thanks,
- Haiyang

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] netvsc: Remove redundant use of ipv6_hdr() Mohammed Gamal <mgamal@redhat.com> - 2017-07-19 15:30 +0200
  RE: [PATCH] netvsc: Remove redundant use of ipv6_hdr() Haiyang Zhang <haiyangz@microsoft.com> - 2017-07-19 17:20 +0200
  Re: [PATCH] netvsc: Remove redundant use of ipv6_hdr() Stephen Hemminger <stephen@networkplumber.org> - 2017-07-19 18:50 +0200
    Re: [PATCH] netvsc: Remove redundant use of ipv6_hdr() Mohammed Gamal <mgamal@redhat.com> - 2017-07-19 19:50 +0200
      Re: [PATCH] netvsc: Remove redundant use of ipv6_hdr() Stephen Hemminger <stephen@networkplumber.org> - 2017-07-19 20:00 +0200
      RE: [PATCH] netvsc: Remove redundant use of ipv6_hdr() Haiyang Zhang <haiyangz@microsoft.com> - 2017-07-19 21:00 +0200
      Re: [PATCH] netvsc: Remove redundant use of ipv6_hdr() Dan Carpenter <dan.carpenter@oracle.com> - 2017-07-19 21:20 +0200

csiph-web