Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1690160

Re: perf: bisected sampling bug in Linux 4.11-rc1

Show all headers | View raw

Vince Weaver <vincent.weaver@maine.edu> writes:

> I was tracking down some regressions in my perf_event_test testsuite.
> Some of the tests broke in the 4.11-rc1 timeframe.
>
> I've bisected one of them, this report is about
> 	tests/overflow/simul_oneshot_group_overflow
> This test creates an event group containing two sampling events, set
> to overflow to a signal handler (which disables and then refreshes the 
> event).
>
> On a good kernel you get the following:
> 	Event perf::instructions with period 1000000
> 	Event perf::instructions with period 2000000
> 		fd 3 overflows: 946 (perf::instructions/1000000)
> 		fd 4 overflows: 473 (perf::instructions/2000000)
> 	Ending counts:
> 		Count 0: 946379875
> 		Count 1: 946365218
>
> With the broken kernels you get:
> 	Event perf::instructions with period 1000000
> 	Event perf::instructions with period 2000000
> 		fd 3 overflows: 938 (perf::instructions/1000000)
> 		fd 4 overflows: 318 (perf::instructions/2000000)
> 	Ending counts:
> 		Count 0: 946373080
> 		Count 1: 653373058
>
>
> 487f05e18aa4efacee6357480f293a5afe6593b5 is the first bad commit
>
> commit 487f05e18aa4efacee6357480f293a5afe6593b5
> Author: Alexander Shishkin <alexander.shishkin@linux.intel.com>
> Date:   Thu Jan 19 18:43:30 2017 +0200

Ok, there was a bug there indeed. This patch should take care of it and
should also be backportable in case it's stable-worthy.

From 187d67c9908cb126656c34546772089c17a8e6c5 Mon Sep 17 00:00:00 2001
From: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Date: Tue, 18 Jul 2017 13:53:01 +0300
Subject: [PATCH] perf: Fix scheduling regression of pinned groups

Commit 487f05e18a ("perf/core: Optimize event rescheduling on active
contexts") erronously assumed that event's 'pinned' setting determines
whether the event belongs to a pinned group or not, but in fact, it's
the group leader's pinned state that matters. This was discovered by
Vince in a test case where two instruction counters are grouped, the
group leader is pinned, but the other event is not; in the regressed
case the counters were off by 33% (the difference between events'
periods), but should be the same within the error margin.

This fixes the problem by looking at the group leader's pinning.

Reported-by: Vince Weaver <vincent.weaver@maine.edu>
Signed-off-by: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Fixes: 487f05e18a ("perf/core: Optimize event rescheduling on active contexts")
Cc: stable@vger.kernel.org
---
 kernel/events/core.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/kernel/events/core.c b/kernel/events/core.c
index bc63f8db1b..1edbaf94dd 100644
--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -1451,6 +1451,13 @@ static enum event_type_t get_event_type(struct perf_event *event)
 
 	lockdep_assert_held(&ctx->lock);
 
+	/*
+	 * It's 'group type', really, because if our group leader is
+	 * pinned, so are we.
+	 */
+	if (event->group_leader != event)
+		event = event->group_leader;
+
 	event_type = event->attr.pinned ? EVENT_PINNED : EVENT_FLEXIBLE;
 	if (!ctx->task)
 		event_type |= EVENT_CPU;
-- 
2.11.0

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

perf: bisected sampling bug in Linux 4.11-rc1 Vince Weaver <vincent.weaver@maine.edu> - 2017-07-14 20:10 +0200
  Re: perf: bisected sampling bug in Linux 4.11-rc1 Vince Weaver <vincent.weaver@maine.edu> - 2017-07-14 20:30 +0200
  Re: perf: bisected sampling bug in Linux 4.11-rc1 Alexander Shishkin <alexander.shishkin@linux.intel.com> - 2017-07-14 22:10 +0200
    Re: perf: bisected sampling bug in Linux 4.11-rc1 Vince Weaver <vincent.weaver@maine.edu> - 2017-07-14 22:20 +0200
  Re: perf: bisected sampling bug in Linux 4.11-rc1 Ingo Molnar <mingo@kernel.org> - 2017-07-15 13:10 +0200
    Re: perf: bisected sampling bug in Linux 4.11-rc1 Vince Weaver <vincent.weaver@maine.edu> - 2017-07-15 16:40 +0200
      Re: perf: bisected sampling bug in Linux 4.11-rc1 Vince Weaver <vincent.weaver@maine.edu> - 2017-07-16 05:10 +0200
    [tip:perf/urgent] Revert "perf/core: Optimize event rescheduling on  active contexts" tip-bot for Ingo Molnar <tipbot@zytor.com> - 2017-07-18 12:50 +0200
  Re: perf: bisected sampling bug in Linux 4.11-rc1 Alexander Shishkin <alexander.shishkin@linux.intel.com> - 2017-07-18 13:20 +0200
    Re: perf: bisected sampling bug in Linux 4.11-rc1 Ingo Molnar <mingo@kernel.org> - 2017-07-18 14:20 +0200
      Re: perf: bisected sampling bug in Linux 4.11-rc1 Vince Weaver <vincent.weaver@maine.edu> - 2017-07-20 05:40 +0200
    [tip:perf/urgent] perf/core: Fix scheduling regression of pinned  groups tip-bot for Alexander Shishkin <tipbot@zytor.com> - 2017-07-20 10:50 +0200

csiph-web