Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1690049

Re: [PATCH 1/2] ARM: OMAP2+: hsmmc.c: Remove dead code

Show all headers | View raw

Hi Ulfe,

I just wanted to make sure that no regressions happen on pandora board.
I have tested this on dra71x-evm.

Regards,
Faiz

On Monday 17 July 2017 06:38 PM, Ulf Hansson wrote:
> On 14 July 2017 at 14:46, Faiz Abbas <faiz_abbas@ti.com> wrote:
>> Most platforms using OMAP hsmmc driver have switched to device tree
>> for passing platform data to omap_hsmmc.c driver.
>>
>> The hsmmc.c file in mach-omap2 exists only to support pandora board
>> which uses wl1251 driver in legacy platform data mode.
>>
>> Hence, remove the dead code not used by the pandora board.
>>
>> Signed-off-by: Faiz Abbas <faiz_abbas@ti.com>
> 
> I just got an ack from Tony to pick this up. So I did that (including
> the mmc change in patch 2) and intend to send this for 4.13 rcs, via
> my fixes branch in my mmc tree.
> 
> However the below comment for testing puzzles me. Either it's dead
> code or not, so then what is there to test? :-)
> 
> Anyway, it's available on my fixes and next branch, so let's see if
> zero build reports some issues.
> 
>> ---
>> This is only compile tested. Someone with a pandora board should help
>> test this for functionality.
>>
>>  arch/arm/mach-omap2/hsmmc.c | 239 +-------------------------------------------
>>  arch/arm/mach-omap2/hsmmc.h |   9 --
>>  2 files changed, 2 insertions(+), 246 deletions(-)
> 
> [...]
> 
> Kind regards
> Uffe
> 

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] ARM: OMAP2+: hsmmc.c: Remove dead code Faiz Abbas <faiz_abbas@ti.com> - 2017-07-14 14:50 +0200
  Re: [PATCH 1/2] ARM: OMAP2+: hsmmc.c: Remove dead code Ulf Hansson <ulf.hansson@linaro.org> - 2017-07-17 15:10 +0200
    Re: [PATCH 1/2] ARM: OMAP2+: hsmmc.c: Remove dead code Faiz Abbas <faiz_abbas@ti.com> - 2017-07-18 12:30 +0200

csiph-web