Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1690008

[PATCH] devfreq: simple_ondemand: Update devfreq stats when governor started

Show all headers | View raw

If governor suspends soon after started, it may not have the chance to
update devfreq stats, which leaves devfreq stats' current frequence be
zero.

So when the thermal core tries to throttle the power, it would failed
to get the correct static power of current frequence and print these
warnings:
[    2.024735] core: dev_pm_opp_get_voltage: Invalid parameters
[    2.024743] mali ff9a0000.gpu: Failed to get voltage for frequency 0:
-34
...
[    2.026320] core: dev_pm_opp_get_voltage: Invalid parameters
[    2.026327] mali ff9a0000.gpu: Failed to get voltage for frequency 0:
-34

Update devfreq stats when governor started to avoid that.

Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
---

 drivers/devfreq/governor_simpleondemand.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/devfreq/governor_simpleondemand.c b/drivers/devfreq/governor_simpleondemand.c
index ae72ba5..26e0e58 100644
--- a/drivers/devfreq/governor_simpleondemand.c
+++ b/drivers/devfreq/governor_simpleondemand.c
@@ -98,6 +98,7 @@ static int devfreq_simple_ondemand_handler(struct devfreq *devfreq,
 {
 	switch (event) {
 	case DEVFREQ_GOV_START:
+		devfreq_update_stats(devfreq);
 		devfreq_monitor_start(devfreq);
 		break;
 
-- 
2.1.4

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] devfreq: simple_ondemand: Update devfreq stats when governor started Jeffy Chen <jeffy.chen@rock-chips.com> - 2017-07-18 12:10 +0200
  RE: [PATCH] devfreq: simple_ondemand: Update devfreq stats when  governor started MyungJoo Ham <myungjoo.ham@samsung.com> - 2017-07-18 12:40 +0200
    Re: [PATCH] devfreq: simple_ondemand: Update devfreq stats when governor  started jeffy <jeffy.chen@rock-chips.com> - 2017-07-18 13:30 +0200
      Re: [PATCH] devfreq: simple_ondemand: Update devfreq stats when governor  started jeffy <jeffy.chen@rock-chips.com> - 2017-07-19 06:30 +0200

csiph-web