Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1689938

Re: [PATCH 2/3] mfd: syscon: atmel-smc: add helper to retrieve register layout

From Lee Jones <lee.jones@linaro.org>
Newsgroups linux.kernel
Subject Re: [PATCH 2/3] mfd: syscon: atmel-smc: add helper to retrieve register layout
Date 2017-07-18 11:40 +0200
Message-ID <u4x90-CI-17@gated-at.bofh.it> (permalink)
References <u1Y5H-7Q0-3@gated-at.bofh.it> <u1Y5I-7Q0-9@gated-at.bofh.it> <u4vTz-8ne-5@gated-at.bofh.it> <u4wPE-w0-27@gated-at.bofh.it> <u4wZm-zm-55@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Tue, 18 Jul 2017, Nicolas Ferre wrote:

> On 18/07/2017 at 11:12, Lee Jones wrote:
> > On Tue, 18 Jul 2017, Lee Jones wrote:
> > 
> >> On Tue, 11 Jul 2017, Ludovic Desroches wrote:
> >>
> >>> For HSMC controller, the register layout depends on the device i.e. the
> >>> offset of setup, pulse, cycle, mode and timings registers is not the
> >>> same. An helper is added to provide the correct register layout.
> >>>
> >>> Fixes: fe9d7cb22ef3 ("mfd: syscon: atmel-smc: Add new helpers to ease
> >>> SMC regs manipulation")
> >>> Suggested-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> >>> Signed-off-by: Ludovic Desroches <ludovic.desroches@microchip.com>
> >>> ---
> >>>  drivers/memory/atmel-ebi.c               | 13 +++++--
> >>>  drivers/mfd/atmel-smc.c                  | 67 +++++++++++++++++++++++++-------
> >>>  drivers/mtd/nand/atmel/nand-controller.c | 10 +++--
> >>>  include/linux/mfd/syscon/atmel-smc.h     | 32 ++++++++++-----
> >>>  4 files changed, 92 insertions(+), 30 deletions(-)
> >>
> >> Applied, thanks.
> > 
> > Apologies, it looks like this needs 2 more Acks before I can even
> > consider taking it.
> > 
> > Unapplied.
> 
> If mine is missing, here it is:
> 
> For the whole series:
> Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
> 
> And I think that Alexandre seemed okay by discussing the path those
> patches should take...

Thanks Anlexadre and Nicolas.

Patch does not apply to v4.13-rc1 however.

Ludovic,

Could you please rebase this patch and apply the 2 new Acks please?

Please also apply my:

For my own reference:
  Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org>

... and I'll get it applied ASAP.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 2/3] mfd: syscon: atmel-smc: add helper to retrieve register layout Ludovic Desroches <ludovic.desroches@microchip.com> - 2017-07-11 09:50 +0200
  Re: [PATCH 2/3] mfd: syscon: atmel-smc: add helper to retrieve  register layout Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-07-11 10:10 +0200
  Re: [PATCH 2/3] mfd: syscon: atmel-smc: add helper to retrieve  register layout Lee Jones <lee.jones@linaro.org> - 2017-07-18 10:20 +0200
    Re: [PATCH 2/3] mfd: syscon: atmel-smc: add helper to retrieve  register layout Lee Jones <lee.jones@linaro.org> - 2017-07-18 11:20 +0200
      Re: [PATCH 2/3] mfd: syscon: atmel-smc: add helper to retrieve  register layout Nicolas Ferre <nicolas.ferre@microchip.com> - 2017-07-18 11:30 +0200
        Re: [PATCH 2/3] mfd: syscon: atmel-smc: add helper to retrieve  register layout Lee Jones <lee.jones@linaro.org> - 2017-07-18 11:40 +0200
          Re: [PATCH 2/3] mfd: syscon: atmel-smc: add helper to retrieve  register layout Ludovic Desroches <ludovic.desroches@microchip.com> - 2017-07-18 12:00 +0200
  Re: [PATCH 2/3] mfd: syscon: atmel-smc: add helper to retrieve  register layout Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2017-07-18 11:30 +0200

csiph-web