Re: [RFC PATCH v12 2/4] random: conditionally compile code depending on LRNG

From	Stephan Müller <smueller@chronox.de>
Newsgroups	linux.kernel
Subject	Re: [RFC PATCH v12 2/4] random: conditionally compile code depending on LRNG
Date	2017-07-18 11:00 +0200
Message-ID	<u4wwj-9E-47@gated-at.bofh.it> (permalink)
References	<u4vTz-8ne-3@gated-at.bofh.it> <u4wcV-8tn-15@gated-at.bofh.it> <u4wmC-51-25@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Am Dienstag, 18. Juli 2017, 10:47:00 CEST schrieb Arnd Bergmann:

Hi Arnd,

> On Tue, Jul 18, 2017 at 10:37 AM, Stephan Müller <smueller@chronox.de> 
wrote:
> > Am Dienstag, 18. Juli 2017, 10:13:55 CEST schrieb Arnd Bergmann:
> >> On Tue, Jul 18, 2017 at 9:58 AM, Stephan Müller <smueller@chronox.de> 
wrote:
> >> > When selecting the LRNG for compilation, disable add_disk_randomness
> >> > and
> >> > its supporting function.
> >> > 
> >> > CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> >> > CC: Arnd Bergmann <arnd@arndb.de>
> >> > CC: Jason A. Donenfeld <Jason@zx2c4.com>
> >> > Signed-off-by: Stephan Mueller <smueller@chronox.de>
> >> 
> >> I think this needs a better explanation. Why do we ignore the extra
> >> entropy here?
> > 
> > I was not sure whether to add all the details about the reason into the
> > patch submission.
> > 
> > The reason is explained here in [1] page 3 and re-iterated in [2].
> 
> Ok, got it. A half-sentence summary of that ("... to avoid adding the
> same event twice from interrupt and block") would be sufficient for
> the patch description, longer is also fine.

Perfect, thank you for that hint. I will add this information to a next 
iteration.
> 
> Generally speaking, each patch description should describe why
> that particular patch is required rather than describe what it does
> (which in cases like this is plain to see from looking a few lines
> down).
> 
>         Arnd



Ciao
Stephan

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[RFC PATCH v12 2/4] random: conditionally compile code depending on LRNG Stephan Müller <smueller@chronox.de> - 2017-07-18 10:20 +0200
  Re: [RFC PATCH v12 2/4] random: conditionally compile code depending  on LRNG Arnd Bergmann <arnd@arndb.de> - 2017-07-18 10:20 +0200
    Re: [RFC PATCH v12 2/4] random: conditionally compile code depending on LRNG Stephan Müller <smueller@chronox.de> - 2017-07-18 10:40 +0200
      Re: [RFC PATCH v12 2/4] random: conditionally compile code depending  on LRNG Arnd Bergmann <arnd@arndb.de> - 2017-07-18 10:50 +0200
        Re: [RFC PATCH v12 2/4] random: conditionally compile code depending on LRNG Stephan Müller <smueller@chronox.de> - 2017-07-18 11:00 +0200

csiph-web