Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1689909

Re: [RFC PATCH v12 1/4] crypto: make Jitter RNG directly accessible

From Arnd Bergmann <arnd@arndb.de>
Newsgroups linux.kernel
Subject Re: [RFC PATCH v12 1/4] crypto: make Jitter RNG directly accessible
Date 2017-07-18 11:20 +0200
Message-ID <u4wPE-w0-23@gated-at.bofh.it> (permalink)
References <u4vTz-8ne-3@gated-at.bofh.it> <u4wwh-9E-1@gated-at.bofh.it> <u4wFX-sD-15@gated-at.bofh.it> <u4wPE-w0-7@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Tue, Jul 18, 2017 at 11:10 AM, Stephan Müller <smueller@chronox.de> wrote:
> Am Dienstag, 18. Juli 2017, 11:02:02 CEST schrieb Arnd Bergmann:
>
> Hi Arnd,
>>
>> I can see why the jitterentropy implementation avoids using kernel headers,
>> the problem now is that part of it gets moved into a new header, and that
>> already violates the original principle.
>>
>> From my reading of the code, we could probably leave the structure
>> definition in the crypto/jitterentropy.c, and have the statically
>> allocated instance in the same file when CONFIG_LRNG is
>> set,
>
> That is a very good idea -- I will implement this approach.

I guess ideally you just move the inner half of lrng_get_jent(),
i.e. everything inside of the spinlock, plus the buffer, into that file.
That should keep the low-level side separate from the caller.

      Arnd

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RFC PATCH v12 1/4] crypto: make Jitter RNG directly accessible Stephan Müller <smueller@chronox.de> - 2017-07-18 10:20 +0200
  Re: [RFC PATCH v12 1/4] crypto: make Jitter RNG directly accessible Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-07-18 10:40 +0200
    Re: [RFC PATCH v12 1/4] crypto: make Jitter RNG directly accessible Stephan Müller <smueller@chronox.de> - 2017-07-18 10:50 +0200
      Re: [RFC PATCH v12 1/4] crypto: make Jitter RNG directly accessible Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-07-18 11:00 +0200
        Re: [RFC PATCH v12 1/4] crypto: make Jitter RNG directly accessible Stephan Müller <smueller@chronox.de> - 2017-07-18 11:00 +0200
        Re: [RFC PATCH v12 1/4] crypto: make Jitter RNG directly accessible Arnd Bergmann <arnd@arndb.de> - 2017-07-18 11:10 +0200
          Re: [RFC PATCH v12 1/4] crypto: make Jitter RNG directly accessible Stephan Müller <smueller@chronox.de> - 2017-07-18 11:20 +0200
            Re: [RFC PATCH v12 1/4] crypto: make Jitter RNG directly accessible Arnd Bergmann <arnd@arndb.de> - 2017-07-18 11:20 +0200
              Re: [RFC PATCH v12 1/4] crypto: make Jitter RNG directly accessible Stephan Müller <smueller@chronox.de> - 2017-07-18 11:20 +0200

csiph-web