Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1689824
| From | Jani Nikula <jani.nikula@linux.intel.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] drm/i915: Explicit the connector name for DP link training result |
| Date | 2017-07-18 09:40 +0200 |
| Message-ID | <u4vgS-7Vc-15@gated-at.bofh.it> (permalink) |
| References | <u4fc7-6e7-27@gated-at.bofh.it> |
| Organization | Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo |
On Mon, 17 Jul 2017, Paul Kocialkowski <paul.kocialkowski@linux.intel.com> wrote:
> This adds the connector name when printing a debug message about the DP
> link training result. It is useful to figure out what connector is
> failing when multiple DP connectors are used.
Perhaps more consistent would be using a prefix like this:
DRM_DEBUG_KMS("[CONNECTOR:%d:%s] bla bla blaa\n",
connector->base.base.id, connector->base.name);
BR,
Jani.
>
> Signed-off-by: Paul Kocialkowski <paul.kocialkowski@linux.intel.com>
> ---
> drivers/gpu/drm/i915/intel_dp_link_training.c | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_dp_link_training.c b/drivers/gpu/drm/i915/intel_dp_link_training.c
> index b79c1c0e404c..75a411c94ce5 100644
> --- a/drivers/gpu/drm/i915/intel_dp_link_training.c
> +++ b/drivers/gpu/drm/i915/intel_dp_link_training.c
> @@ -321,13 +321,15 @@ intel_dp_start_link_train(struct intel_dp *intel_dp)
> if (!intel_dp_link_training_channel_equalization(intel_dp))
> goto failure_handling;
>
> - DRM_DEBUG_KMS("Link Training Passed at Link Rate = %d, Lane count = %d",
> - intel_dp->link_rate, intel_dp->lane_count);
> + DRM_DEBUG_KMS("Link Training Passed at Link Rate = %d, Lane count = %d for connector %s",
> + intel_dp->link_rate, intel_dp->lane_count,
> + intel_connector->base.name);
> return;
>
> failure_handling:
> - DRM_DEBUG_KMS("Link Training failed at link rate = %d, lane count = %d",
> - intel_dp->link_rate, intel_dp->lane_count);
> + DRM_DEBUG_KMS("Link Training failed at link rate = %d, lane count = %d for connector %s",
> + intel_dp->link_rate, intel_dp->lane_count,
> + intel_connector->base.name);
> if (!intel_dp_get_link_train_fallback_values(intel_dp,
> intel_dp->link_rate,
> intel_dp->lane_count))
--
Jani Nikula, Intel Open Source Technology Center
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] drm/i915: Explicit the connector name for DP link training result Paul Kocialkowski <paul.kocialkowski@linux.intel.com> - 2017-07-17 16:30 +0200
Re: [PATCH] drm/i915: Explicit the connector name for DP link training result Jani Nikula <jani.nikula@linux.intel.com> - 2017-07-18 09:40 +0200
Re: [PATCH] drm/i915: Explicit the connector name for DP link training result Paul Kocialkowski <paul.kocialkowski@linux.intel.com> - 2017-07-18 13:30 +0200
csiph-web