Re: [PATCH 1/2] Input: axp20x-pek: add support for AXP221 PEK

From	Quentin Schulz <quentin.schulz@free-electrons.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] Input: axp20x-pek: add support for AXP221 PEK
Date	2017-07-18 10:20 +0200
Message-ID	<u4vTA-8ne-13@gated-at.bofh.it> (permalink)
References	<u4aYO-3lP-7@gated-at.bofh.it> <u4aYO-3lP-5@gated-at.bofh.it> <u4cnU-4lE-19@gated-at.bofh.it> <u4vgT-7Vc-29@gated-at.bofh.it> <u4vAe-81L-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi Maxime,

On 18/07/2017 09:57, Maxime Ripard wrote:
> On Tue, Jul 18, 2017 at 09:36:04AM +0200, Quentin Schulz wrote:
>>>> +
>>>> +	error = sysfs_create_group(&pdev->dev.kobj,
>>>> +				   axp20x_pek->attribute_group);
>>>
>>> Wouldn't it make more sense to just store the startup_time structure
>>> in the axp20x_pek structure, rather than duplicating all this?
>>>
>>
>> I don't know. Basically, you would need to recreate manually all the
>> structures in the probe function, but why not.
> 
> Why?
> 
> You have access to axp20x_pek in the readout function. You can just
> use the table stored in the structure here, and just ignore any
> argument you might have.
> 

All I'm saying is that:
struct axp20x_time is referenced in struct axp20x_pek_ext_attr which in
turn is referenced in struct dev_ext_attribute which is referenced in
struct attribute which is reference in const struct attribute_group
which is finally used to add/remove a sysfs group programmatically.

The earlier in the chain you decide to stop duplicating code, the most
structures you have to programmatically create. That was my point.

Quentin

-- 
Quentin Schulz, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] Input: axp20x-pek: add support for AXP221 PEK Quentin Schulz <quentin.schulz@free-electrons.com> - 2017-07-17 12:00 +0200
  Re: [PATCH 1/2] Input: axp20x-pek: add support for AXP221 PEK Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-07-17 13:30 +0200
    Re: [PATCH 1/2] Input: axp20x-pek: add support for AXP221 PEK Quentin Schulz <quentin.schulz@free-electrons.com> - 2017-07-18 09:40 +0200
      Re: [PATCH 1/2] Input: axp20x-pek: add support for AXP221 PEK Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-07-18 10:00 +0200
        Re: [PATCH 1/2] Input: axp20x-pek: add support for AXP221 PEK Quentin Schulz <quentin.schulz@free-electrons.com> - 2017-07-18 10:20 +0200

csiph-web