Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1689849

Re: [PATCH v3] staging: unisys: visorbus: Constify attribute_group structures.

From Greg KH <gregkh@linuxfoundation.org>
Newsgroups linux.kernel
Subject Re: [PATCH v3] staging: unisys: visorbus: Constify attribute_group structures.
Date 2017-07-18 10:10 +0200
Message-ID <u4vJU-8k9-3@gated-at.bofh.it> (permalink)
References <u4vAd-81L-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Tue, Jul 18, 2017 at 01:24:42PM +0530, Arvind Yadav wrote:
> attribute_group are not supposed to change at runtime. All functions
> working with attribute_group provided by <linux/sysfs.h> work
> with const attribute_group. So mark the non-const structs as const.
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
>  drivers/staging/unisys/visorbus/visorbus_main.c | 4 ++--
>  drivers/staging/unisys/visorbus/visorchipset.c  | 2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)

What changed from the previous patches?  Always include that below the
--- line as maintainers have no short-term memory at all.

v4?

thanks,

greg k-h

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v3] staging: unisys: visorbus: Constify attribute_group structures. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-07-18 10:00 +0200
  Re: [PATCH v3] staging: unisys: visorbus: Constify attribute_group  structures. Greg KH <gregkh@linuxfoundation.org> - 2017-07-18 10:10 +0200
    Re: [PATCH v3] staging: unisys: visorbus: Constify attribute_group  structures. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-07-18 10:20 +0200

csiph-web