Re: [PATCH v4 15/16] perf tools: add feature header record to pipe-mode

From	David Carrillo-Cisneros <davidcc@google.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v4 15/16] perf tools: add feature header record to pipe-mode
Date	2017-07-18 06:40 +0200
Message-ID	<u4ssG-6bP-23@gated-at.bofh.it> (permalink)
References	<tRLMt-3kB-3@gated-at.bofh.it> <tRLMt-3kB-5@gated-at.bofh.it> <tRZcK-380-11@gated-at.bofh.it> <u2dR8-Vf-21@gated-at.bofh.it> <u2kpz-5f6-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Jul 12, 2017 at 12:38 AM, Jiri Olsa <jolsa@redhat.com> wrote:
> On Tue, Jul 11, 2017 at 05:32:40PM -0700, David Carrillo-Cisneros wrote:
>> On Tue, Jun 13, 2017 at 11:54 AM, Jiri Olsa <jolsa@redhat.com> wrote:
>> > On Mon, Jun 12, 2017 at 09:29:31PM -0700, David Carrillo-Cisneros wrote:
>> >
>> > SNIP
>> >
>> >>
>> >>  void perf_event__print_totals(void);
>> >> diff --git a/tools/perf/util/header.c b/tools/perf/util/header.c
>> >> index ddfaf157913d..6f6a54c15cb0 100644
>> >> --- a/tools/perf/util/header.c
>> >> +++ b/tools/perf/util/header.c
>> >> @@ -34,6 +34,7 @@
>> >>  #include "data.h"
>> >>  #include <api/fs/fs.h>
>> >>  #include "asm/bug.h"
>> >> +#include "tool.h"
>> >>
>> >>  #include "sane_ctype.h"
>> >>
>> >> @@ -97,11 +98,14 @@ static int __do_write_buf(struct feat_fd *ff,  const void *buf, size_t size)
>> >>
>> >>  retry:
>> >>       if (size > (ff->size - ff->offset)) {
>> >> -             addr = realloc(ff->buf, ff->size << 1);
>> >> +             size = ff->size << 1;
>> >> +             if (size > page_size)
>> >
>> > event size could be 0xffff - sizeof(struct perf_event_header)
>> > also the initial size is most likely > page_size anyway
>> >
>> > please put this into the patch that introduced __do_write_buf
>> >
>>
>> Thank you for reviewing this. I just realized that I sent v5 without
>> properly addressing this issue. In v4 I tried to add a quick check
>> without properly understanding the issue. Why is 0xffff the maximum
>> size for an event? where is this constraint coming from?
>
> the struct perf_event_header::size is u16

ok, it makes sense now. I submitted v6, hopefully handling the resize properly.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v4 15/16] perf tools: add feature header record to pipe-mode David Carrillo-Cisneros <davidcc@google.com> - 2017-07-12 02:40 +0200
  Re: [PATCH v4 15/16] perf tools: add feature header record to  pipe-mode Jiri Olsa <jolsa@redhat.com> - 2017-07-12 09:40 +0200
    Re: [PATCH v4 15/16] perf tools: add feature header record to pipe-mode David Carrillo-Cisneros <davidcc@google.com> - 2017-07-18 06:40 +0200

csiph-web