Re: [PATCH] usb: dwc2: gadget: On USB RESET reset device address to zero

From	John Youn <John.Youn@synopsys.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] usb: dwc2: gadget: On USB RESET reset device address to zero
Date	2017-07-18 05:30 +0200
Message-ID	<u4rmW-5vl-23@gated-at.bofh.it> (permalink)
References	<u20Ay-11v-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 07/11/2017 03:25 AM, Minas Harutyunyan wrote:
> Reseted DEVADDR field in DCFG to zero on USB RESET.
>
> Device address in DCFG register does not reset to zero,
> which required to pass enumeration, after disconnect and
> reconnect.
>
> Signed-off-by: Minas Harutyunyan <hminas@synopsys.com>
> ---
>  drivers/usb/dwc2/gadget.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c
> index 98a4a79e7f6e..c5c0a26a4d66 100644
> --- a/drivers/usb/dwc2/gadget.c
> +++ b/drivers/usb/dwc2/gadget.c
> @@ -3561,6 +3561,9 @@ static irqreturn_t dwc2_hsotg_irq(int irq, void *pw)
>  		/* Report disconnection if it is not already done. */
>  		dwc2_hsotg_disconnect(hsotg);
>
> +		/* Reset device address to zero */
> +		__bic32(hsotg->regs + DCFG, DCFG_DEVADDR_MASK);
> +
>  		if (usb_status & GOTGCTL_BSESVLD && connected)
>  			dwc2_hsotg_core_init_disconnected(hsotg, true);
>  	}
>

Acked-by: John Youn <johnyoun@synopsys.com>


John

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] usb: dwc2: gadget: On USB RESET reset device address to zero Minas Harutyunyan <Minas.Harutyunyan@synopsys.com> - 2017-07-11 12:30 +0200
  Re: [PATCH] usb: dwc2: gadget: On USB RESET reset device address to  zero John Youn <John.Youn@synopsys.com> - 2017-07-18 05:30 +0200

csiph-web