Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1689592
| From | Byungchul Park <byungchul.park@lge.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v7 06/16] lockdep: Detect and handle hist_lock ring buffer overwrite |
| Date | 2017-07-18 03:30 +0200 |
| Message-ID | <u4puN-4ho-1@gated-at.bofh.it> (permalink) |
| References | (2 earlier) <u263f-4Bc-7@gated-at.bofh.it> <u2fgd-1TD-11@gated-at.bofh.it> <u2kIV-5nd-15@gated-at.bofh.it> <u2BJL-7RV-1@gated-at.bofh.it> <u2HvP-37W-9@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Thu, Jul 13, 2017 at 10:14:42AM +0200, Peter Zijlstra wrote:
> +static void __crossrelease_end(unsigned int *stamp)
> +{
[snip]
> +
> + /*
> + * If we rewind past the tail; all of history is lost.
> + */
> + if ((current->xhlock_idx_max - *stamp) < MAX_XHLOCKS_NR)
> + return;
> +
> + /*
> + * Invalidate the entire history..
> + */
> + for (i = 0; i < MAX_XHLOCKS_NR; i++)
> + invalidate_xhlock(&xhlock(i));
> +
> + current->xhlock_idx = 0;
> + current->xhlock_idx_hard = 0;
> + current->xhlock_idx_soft = 0;
> + current->xhlock_idx_hist = 0;
> + current->xhlock_idx_max = 0;
I don't understand why you introduced this code, yet. Do we need this?
The other of your suggestion looks very good though..
> +}
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
Re: [PATCH v7 06/16] lockdep: Detect and handle hist_lock ring buffer overwrite Peter Zijlstra <peterz@infradead.org> - 2017-07-11 18:20 +0200
Re: [PATCH v7 06/16] lockdep: Detect and handle hist_lock ring buffer overwrite Byungchul Park <byungchul.park@lge.com> - 2017-07-12 04:10 +0200
Re: [PATCH v7 06/16] lockdep: Detect and handle hist_lock ring buffer overwrite Peter Zijlstra <peterz@infradead.org> - 2017-07-12 10:00 +0200
Re: [PATCH v7 06/16] lockdep: Detect and handle hist_lock ring buffer overwrite Byungchul Park <byungchul.park@lge.com> - 2017-07-13 04:10 +0200
Re: [PATCH v7 06/16] lockdep: Detect and handle hist_lock ring buffer overwrite Peter Zijlstra <peterz@infradead.org> - 2017-07-13 10:20 +0200
Re: [PATCH v7 06/16] lockdep: Detect and handle hist_lock ring buffer overwrite Byungchul Park <byungchul.park@lge.com> - 2017-07-13 11:00 +0200
Re: [PATCH v7 06/16] lockdep: Detect and handle hist_lock ring buffer overwrite Peter Zijlstra <peterz@infradead.org> - 2017-07-13 12:00 +0200
Re: [PATCH v7 06/16] lockdep: Detect and handle hist_lock ring buffer overwrite Byungchul Park <byungchul.park@lge.com> - 2017-07-13 12:20 +0200
Re: [PATCH v7 06/16] lockdep: Detect and handle hist_lock ring buffer overwrite Peter Zijlstra <peterz@infradead.org> - 2017-07-13 12:30 +0200
Re: [PATCH v7 06/16] lockdep: Detect and handle hist_lock ring buffer overwrite Peter Zijlstra <peterz@infradead.org> - 2017-07-13 13:20 +0200
Re: [PATCH v7 06/16] lockdep: Detect and handle hist_lock ring buffer overwrite Byungchul Park <max.byungchul.park@gmail.com> - 2017-07-13 13:30 +0200
Re: [PATCH v7 06/16] lockdep: Detect and handle hist_lock ring buffer overwrite Byungchul Park <byungchul.park@lge.com> - 2017-07-14 03:50 +0200
Re: [PATCH v7 06/16] lockdep: Detect and handle hist_lock ring buffer overwrite Byungchul Park <byungchul.park@lge.com> - 2017-07-14 08:50 +0200
Re: [PATCH v7 06/16] lockdep: Detect and handle hist_lock ring buffer overwrite Peter Zijlstra <peterz@infradead.org> - 2017-07-21 16:00 +0200
Re: [PATCH v7 06/16] lockdep: Detect and handle hist_lock ring buffer overwrite Byungchul Park <byungchul.park@lge.com> - 2017-07-25 08:40 +0200
Re: [PATCH v7 06/16] lockdep: Detect and handle hist_lock ring buffer overwrite Peter Zijlstra <peterz@infradead.org> - 2017-07-25 10:50 +0200
Re: [PATCH v7 06/16] lockdep: Detect and handle hist_lock ring buffer overwrite Byungchul Park <max.byungchul.park@gmail.com> - 2017-07-13 13:20 +0200
Re: [PATCH v7 06/16] lockdep: Detect and handle hist_lock ring buffer overwrite Byungchul Park <byungchul.park@lge.com> - 2017-07-18 03:30 +0200
csiph-web