Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1689420

[GIT pull] smp fix for 4.13

Show all headers | View raw

Linus,

please pull the latest smp-urgent-for-linus git tree from:

   git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git smp-urgent-for-linus

Replace the bogus BUG_ON in the cpu hotplug code.

Thanks,

	tglx

------------------>
Thomas Gleixner (1):
      smp/hotplug: Replace BUG_ON and react useful


 kernel/cpu.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/kernel/cpu.c b/kernel/cpu.c
index ab860453841d..eee033134262 100644
--- a/kernel/cpu.c
+++ b/kernel/cpu.c
@@ -279,7 +279,8 @@ static int bringup_wait_for_ap(unsigned int cpu)
 
 	/* Wait for the CPU to reach CPUHP_AP_ONLINE_IDLE */
 	wait_for_completion(&st->done);
-	BUG_ON(!cpu_online(cpu));
+	if (WARN_ON_ONCE((!cpu_online(cpu))))
+		return -ECANCELED;
 
 	/* Unpark the stopper thread and the hotplug thread of the target cpu */
 	stop_machine_unpark(cpu);

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[GIT pull] smp fix for 4.13 Thomas Gleixner <tglx@linutronix.de> - 2017-07-17 22:00 +0200

csiph-web