Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1689445
| From | David Miller <davem@davemloft.net> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 08/11] net: cadence: macb: constify pci_device_id. |
| Date | 2017-07-17 22:40 +0200 |
| Message-ID | <u4kYa-1mN-5@gated-at.bofh.it> (permalink) |
| References | <u4iMF-8w3-1@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
From: Arvind Yadav <arvind.yadav.cs@gmail.com> Date: Mon, 17 Jul 2017 23:41:52 +0530 > pci_device_id are not supposed to change at runtime. All functions > working with pci_device_id provided by <linux/pci.h> work with > const pci_device_id. So mark the non-const structs as const. > > File size before: > text data bss dec hex filename > 791 336 0 1127 467 net/ethernet/cadence/macb_pci.o > > File size After adding 'const': > text data bss dec hex filename > 855 272 0 1127 467 net/ethernet/cadence/macb_pci.o > > Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> Applied.
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[PATCH 08/11] net: cadence: macb: constify pci_device_id. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-07-17 20:20 +0200 Re: [PATCH 08/11] net: cadence: macb: constify pci_device_id. David Miller <davem@davemloft.net> - 2017-07-17 22:40 +0200
csiph-web