Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1689438

Re: [PATCH 01/11] rtlwifi: rtl8192de: constify pci_device_id.

From Larry Finger <Larry.Finger@lwfinger.net>
Newsgroups linux.kernel
Subject Re: [PATCH 01/11] rtlwifi: rtl8192de: constify pci_device_id.
Date 2017-07-17 22:20 +0200
Message-ID <u4kEO-1f3-29@gated-at.bofh.it> (permalink)
References <u4iMG-8w3-13@gated-at.bofh.it> <u4iMG-8w3-31@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On 07/17/2017 01:09 PM, Arvind Yadav wrote:
> pci_device_id are not supposed to change at runtime. All functions
> working with pci_device_id provided by <linux/pci.h> work with
> const pci_device_id. So mark the non-const structs as const.
> 
> File size before:
>     text	   data	    bss	    dec	    hex	filename
>     2833	    945	     12	   3790	    ece realtek/rtlwifi/rtl8192de/sw.o
> 
> File size After adding 'const':
>     text	   data	    bss	    dec	    hex	filename
>     2929	    849	     12	   3790	    ece realtek/rtlwifi/rtl8192de/sw.o
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>

Acked-by: Larry Finger <Larry.Finger@lwfinger.net>

This applies to all 11.

Thanks,

Larry

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 00/11] constify net pci_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-07-17 20:20 +0200
  [PATCH 03/11] rtlwifi: rtl8821ae: constify pci_device_id. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-07-17 20:20 +0200
  [PATCH 06/11] rtlwifi: rtl8188ee: constify pci_device_id. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-07-17 20:20 +0200
  [PATCH 04/11] rtlwifi: rtl8723ae: constify pci_device_id. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-07-17 20:20 +0200
  [PATCH 01/11] rtlwifi: rtl8192de: constify pci_device_id. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-07-17 20:20 +0200
    Re: [PATCH 01/11] rtlwifi: rtl8192de: constify pci_device_id. Larry Finger <Larry.Finger@lwfinger.net> - 2017-07-17 22:20 +0200
  [PATCH 05/11] rtlwifi: rtl8723be: constify pci_device_id. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-07-17 20:20 +0200
  [PATCH 02/11] rtlwifi: rtl8192se: constify pci_device_id. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-07-17 20:20 +0200

csiph-web