Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1689354

Re: [PATCH 1/2] dt-binding: mfd: Add Maxim/Dallas DS1374 MFD device binding

From Rob Herring <robh@kernel.org>
Newsgroups linux.kernel
Subject Re: [PATCH 1/2] dt-binding: mfd: Add Maxim/Dallas DS1374 MFD device binding
Date 2017-07-17 21:00 +0200
Message-ID <u4jpp-hn-35@gated-at.bofh.it> (permalink)
References <u2Srf-1rA-11@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Thu, Jul 13, 2017 at 12:54:24PM -0700, Moritz Fischer wrote:
> This adds a binding for the Maxim/Dallas DS1374 MFD.
> 
> Signed-off-by: Moritz Fischer <mdf@kernel.org>
> ---
> Changes from RFC:
> - dallas,ds1374-mode -> dallas,mode
> - Clarified examples
> - dallas,remap-reset property
> 
> On second thoughts the solution for the remapping found in the
> discussion did not seem to be a good solution, since the INT
> pin indicating watchdog reset does not necessarily have to be
> connected to an interrupt line on the machine, it could equally
> well be hooked up to a PMIC reset input or similar.
> In that case using the presence of an 'interrupt' phandle is not
> a good choice.
> 
> Cheers,
> 
> Moritz
> 
> ---
>  Documentation/devicetree/bindings/mfd/ds1374.txt   | 88 ++++++++++++++++++++++
>  .../devicetree/bindings/trivial-devices.txt        |  1 -
>  drivers/rtc/Kconfig                                |  2 +

This belongs in patch 2. With that dropped,

Acked-by: Rob Herring <robh@kernel.org>

>  3 files changed, 90 insertions(+), 1 deletion(-)
>  create mode 100644 Documentation/devicetree/bindings/mfd/ds1374.txt

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 1/2] dt-binding: mfd: Add Maxim/Dallas DS1374 MFD device binding Moritz Fischer <mdf@kernel.org> - 2017-07-13 22:00 +0200
  Re: [PATCH 2/2] mfd: ds1374: Add Dallas/Maxim DS1374 Multi Function  Device Guenter Roeck <linux@roeck-us.net> - 2017-07-14 21:30 +0200
  Re: [PATCH 2/2] mfd: ds1374: Add Dallas/Maxim DS1374 Multi Function  Device Lee Jones <lee.jones@linaro.org> - 2017-07-17 10:00 +0200
    Re: [PATCH 2/2] mfd: ds1374: Add Dallas/Maxim DS1374 Multi Function  Device Moritz Fischer <mdf@kernel.org> - 2017-07-17 20:20 +0200
      Re: [PATCH 2/2] mfd: ds1374: Add Dallas/Maxim DS1374 Multi Function  Device Lee Jones <lee.jones@linaro.org> - 2017-07-18 11:30 +0200
  Re: [PATCH 1/2] dt-binding: mfd: Add Maxim/Dallas DS1374 MFD device  binding Rob Herring <robh@kernel.org> - 2017-07-17 21:00 +0200
  Re: [PATCH 1/2] dt-binding: mfd: Add Maxim/Dallas DS1374 MFD device  binding Lee Jones <lee.jones@linaro.org> - 2017-07-18 11:30 +0200

csiph-web