Re: [PATCH 11/11] net: brcmfmac: constify pci_device_id.

From	Arend van Spriel <arend.vanspriel@broadcom.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 11/11] net: brcmfmac: constify pci_device_id.
Date	2017-07-17 21:30 +0200
Message-ID	<u4jSq-Gx-19@gated-at.bofh.it> (permalink)
References	<u4iMH-8w3-37@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


On 17-07-17 20:16, Arvind Yadav wrote:
> pci_device_id are not supposed to change at runtime. All functions
> working with pci_device_id provided by <linux/pci.h> work with
> const pci_device_id. So mark the non-const structs as const.

Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
>  drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c
> index f878706..e6e9b00 100644
> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c
> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c
> @@ -1951,7 +1951,7 @@ static const struct dev_pm_ops brcmf_pciedrvr_pm = {
>  	BRCM_PCIE_VENDOR_ID_BROADCOM, dev_id,\
>  	subvend, subdev, PCI_CLASS_NETWORK_OTHER << 8, 0xffff00, 0 }
>  
> -static struct pci_device_id brcmf_pcie_devid_table[] = {
> +static const struct pci_device_id brcmf_pcie_devid_table[] = {
>  	BRCMF_PCIE_DEVICE(BRCM_PCIE_4350_DEVICE_ID),
>  	BRCMF_PCIE_DEVICE(BRCM_PCIE_4356_DEVICE_ID),
>  	BRCMF_PCIE_DEVICE(BRCM_PCIE_43567_DEVICE_ID),
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 11/11] net: brcmfmac: constify pci_device_id. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-07-17 20:20 +0200
  Re: [PATCH 11/11] net: brcmfmac: constify pci_device_id. Arend van Spriel <arend.vanspriel@broadcom.com> - 2017-07-17 21:30 +0200

csiph-web