Re: [RFC PATCH 1/2] mmc: sdhci: add quirk SDHCI_QUIRK2_BROKEN_SDMA_BOUNDARY_BUFFER

From	Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [RFC PATCH 1/2] mmc: sdhci: add quirk SDHCI_QUIRK2_BROKEN_SDMA_BOUNDARY_BUFFER
Date	2017-07-17 19:00 +0200
Message-ID	<u4hxf-7xZ-3@gated-at.bofh.it> (permalink)
References	<tXlmh-7nt-3@gated-at.bofh.it> <tXlmh-7nt-1@gated-at.bofh.it> <u23RP-31D-107@gated-at.bofh.it> <u4dMZ-57W-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


On 17/07/17 13:47, Adrian Hunter wrote:
>> This change seems like a reasonable justification for adding a new
>> SDHCI quirk, even if we in general wants to avoid that.
>>
>> Adrian?
> If we add a quirk for every register we end up with a very ugly version of
> CONFIG_MMC_SDHCI_IO_ACCESSORS.  So CONFIG_MMC_SDHCI_IO_ACCESSORS is a better
> option.  Another possibility is to add a member to struct sdhci_host,
> initialized to SDHCI_DEFAULT_BOUNDARY_ARG, and write that.  Drivers could
> then change the value if necessary.
Second option seems to be better one. I will give it a try and see!

thanks,
srini

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [RFC PATCH 1/2] mmc: sdhci: add quirk SDHCI_QUIRK2_BROKEN_SDMA_BOUNDARY_BUFFER Ulf Hansson <ulf.hansson@linaro.org> - 2017-07-11 16:00 +0200
  Re: [RFC PATCH 1/2] mmc: sdhci: add quirk  SDHCI_QUIRK2_BROKEN_SDMA_BOUNDARY_BUFFER Adrian Hunter <adrian.hunter@intel.com> - 2017-07-17 15:00 +0200
    Re: [RFC PATCH 1/2] mmc: sdhci: add quirk  SDHCI_QUIRK2_BROKEN_SDMA_BOUNDARY_BUFFER Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2017-07-17 19:00 +0200

csiph-web