Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1689237

[PATCH] mmc: host: via-sdmmc: constify pci_device_id.

Path csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From Arvind Yadav <arvind.yadav.cs@gmail.com>
Newsgroups linux.kernel
Subject [PATCH] mmc: host: via-sdmmc: constify pci_device_id.
Date Mon, 17 Jul 2017 18:40:02 +0200
Message-ID <u4hdU-7rt-9@gated-at.bofh.it> (permalink)
X-Original-To brucechang@via.com.tw, HaraldWelte@viatech.com, ulf.hansson@linaro.org
Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=K+CA1/vWNGq0sjbzvhT+H9s+GNqpBLvk/7XqGG4cIOA=; b=SGFOYQyEGt5Xsw1MzItk0lr/V/WhY2km6zNHDzarCMHQH/SUP2lDdGBGh2GMsCSzYZ o4svpKhgAEyj0ifyrYfhhH3sCG+3hO+FPOoEeW4mCJlBQQMMISs6m/HUsikIYetqJ1Dp blMqMgYLaE+9tlrGp6p1h6xNZDeF4kIr9TDLDTgSSDCN1nJFXMpv1gtqpUKOrEu9qIOY 6kMB49QZBRWEn5KevFOylHajlXbQsHjvRxIsCP4xVptfOniPSNuw8qoKSrOpz6OG14CF inyALJteZuPj6Ar3NsRGhaeEBHQH0WTWn7Oj0/cXcZLMfMjNMgT/b0FqNvUZ3MurtgKw 49hA==
X-Google-Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=K+CA1/vWNGq0sjbzvhT+H9s+GNqpBLvk/7XqGG4cIOA=; b=h863s369HsLf8WfmKwITqZDtdIWDWoBP3qyxk015Yq3948mCmHfSzKMx/Sc0jE/LLI O2OhR4pnJJkM2Fgf4voQGfhVw1OEAHRzDSn74XkNkcvxPo+6/zoDRnUl70NSyjYgLU79 gQvHMH8xubjuujUFUXp90RdaWWHMKfOUNg1OCOKW+QJ364SQK+GxEJqBcSovQ+KjOM23 N5Mb0Co+5tcTLluuiB64yYaK4VE+grTjaNRP1qrEmLPDn9vc86PoLXL17meSh2u74XJE ojXjP1e3pW/HviZuuobQfR7Ds0Rqdl/G3lxquwDNJQmoM2bEbmRkehHzCM7QZlBZ0+M/ k2Ng==
X-Gm-Message-State AIVw112yFhg5xyqIqSGpAPkwFozdPdj8oD4gawguXd093PMbmED/AzEc zC17a/z5lx5gpg==
X-Received by 10.98.155.133 with SMTP id e5mr5757018pfk.186.1500309103462; Mon, 17 Jul 2017 09:31:43 -0700 (PDT)
X-Mailer git-send-email 2.7.4
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 32
Organization linux.* mail to news gateway
X-Original-Cc linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org
X-Original-Date Mon, 17 Jul 2017 22:01:33 +0530
X-Original-Message-ID <6e5268522c9f41b6f6b6d9a3f70212b641042bb1.1500309009.git.arvind.yadav.cs@gmail.com>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1689237

Show key headers only | View raw


pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.

File size before:
   text	   data	    bss	    dec	    hex	filename
   6952	    880	      0	   7832	   1e98	drivers/mmc/host/via-sdmmc.o

File size After adding 'const':
   text	   data	    bss	    dec	    hex	filename
   7032	    800	      0	   7832	   1e98	drivers/mmc/host/via-sdmmc.o

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
 drivers/mmc/host/via-sdmmc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mmc/host/via-sdmmc.c b/drivers/mmc/host/via-sdmmc.c
index 6380044..a838bf5 100644
--- a/drivers/mmc/host/via-sdmmc.c
+++ b/drivers/mmc/host/via-sdmmc.c
@@ -323,7 +323,7 @@ struct via_crdr_mmc_host {
 /* some devices need a very long delay for power to stabilize */
 #define VIA_CRDR_QUIRK_300MS_PWRDELAY	0x0001
 
-static struct pci_device_id via_ids[] = {
+static const struct pci_device_id via_ids[] = {
 	{PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_9530,
 	  PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0,},
 	{0,}
-- 
2.7.4

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

[PATCH] mmc: host: via-sdmmc: constify pci_device_id. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-07-17 18:40 +0200

csiph-web