Re: [PATCH] timer-of: handle of_irq_get() result correctly

From	Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] timer-of: handle of_irq_get() result correctly
Date	2017-07-17 19:20 +0200
Message-ID	<u4hQB-7W1-7@gated-at.bofh.it> (permalink)
References	<u3XRT-3jE-3@gated-at.bofh.it>
Organization	Cogent Embedded

Show all headers | View raw

Hello!

On 07/16/2017 10:55 PM, Sergei Shtylyov wrote:

> of_irq_get_byname() may return a negative error number as well as 0 on
> failure, while timer_irq_init() only checks for 0, blithely continuing with
> the call to request_[percpu_]irq() -- those functions expect *unsigned int*,
> so would probably fail anyway when a large IRQ number resulting from a
> conversion of a negative error number is passed to them... This, however,
> is incorrect behavior -- error number is not IRQ number.
>
> Fileter out the negative error numbers, complain, and return them to the

    Oops, a typo. And the subject should have of_irq_get_byname(). I'll repost.

> timer_irq_init()'s callers...
>
> Fixes: dc11bae78529 ("clocksource/drivers: Add timer-of common init routine")
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
[...]

MBR, Sergei

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] timer-of: handle of_irq_get() result correctly Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2017-07-16 22:00 +0200
  Re: [PATCH] timer-of: handle of_irq_get() result correctly Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2017-07-17 19:20 +0200

csiph-web