Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1689230

Re: [PATCH net] jhash: fix -Wimplicit-fallthrough warnings

Path csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!news.servidellagleba.it!bofh.it!news.nic.it!robomod
From David Miller <davem@davemloft.net>
Newsgroups linux.kernel
Subject Re: [PATCH net] jhash: fix -Wimplicit-fallthrough warnings
Date Mon, 17 Jul 2017 18:30:02 +0200
Message-ID <u4h4e-7oe-13@gated-at.bofh.it> (permalink)
References <u3or8-6hS-3@gated-at.bofh.it>
X-Original-To jakub.kicinski@netronome.com
X-Mailer Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO)
MIME-Version 1.0
Content-Type Text/Plain; charset=us-ascii
Content-Transfer-Encoding 7bit
X-Greylist Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 17 Jul 2017 09:23:29 -0700 (PDT)
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 13
Organization linux.* mail to news gateway
X-Original-Cc netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kadlec@blackhole.kfki.hu, oss-drivers@netronome.com
X-Original-Date Mon, 17 Jul 2017 09:23:28 -0700 (PDT)
X-Original-Message-ID <20170717.092328.27327361173214982.davem@davemloft.net>
X-Original-References <20170715060349.2464-1-jakub.kicinski@netronome.com>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1689230

Show key headers only | View raw


From: Jakub Kicinski <jakub.kicinski@netronome.com>
Date: Fri, 14 Jul 2017 23:03:49 -0700

> GCC 7 added a new -Wimplicit-fallthrough warning.  It's only enabled
> with W=1, but since linux/jhash.h is included in over hundred places
> (including other global headers) it seems worthwhile fixing this
> warning.
> 
> Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
> ---
> If it looks good, would it be OK to take it via the net tree?

Applied, thanks Jakub.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread


Thread

[PATCH net] jhash: fix -Wimplicit-fallthrough warnings Jakub Kicinski <jakub.kicinski@netronome.com> - 2017-07-15 08:10 +0200
  Re: [PATCH net] jhash: fix -Wimplicit-fallthrough warnings David Miller <davem@davemloft.net> - 2017-07-17 18:30 +0200

csiph-web