Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1689193

Re: [PATCH] drm/vgem: add compat_ioctl support

Show all headers | View raw

On Fri, Jul 14, 2017 at 08:12:12PM -0700, Brian Norris wrote:
> DRM drivers should supply a compat version if they're going to provide
> an ioctl implementation at all. This can confuse 32-bit user space on a
> 64-bit system.
> 
> Signed-off-by: Brian Norris <briannorris@chromium.org>

Thanks, applied.
-Daniel

> ---
>  drivers/gpu/drm/vgem/vgem_drv.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/vgem/vgem_drv.c b/drivers/gpu/drm/vgem/vgem_drv.c
> index 9fee38a942c4..3835656e2baf 100644
> --- a/drivers/gpu/drm/vgem/vgem_drv.c
> +++ b/drivers/gpu/drm/vgem/vgem_drv.c
> @@ -220,6 +220,7 @@ static const struct file_operations vgem_driver_fops = {
>  	.poll		= drm_poll,
>  	.read		= drm_read,
>  	.unlocked_ioctl = drm_ioctl,
> +	.compat_ioctl	= drm_compat_ioctl,
>  	.release	= drm_release,
>  };
>  
> -- 
> 2.13.2.932.g7449e964c-goog
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] drm/vgem: add compat_ioctl support Brian Norris <briannorris@chromium.org> - 2017-07-15 05:20 +0200
  Re: [PATCH] drm/vgem: add compat_ioctl support Daniel Vetter <daniel@ffwll.ch> - 2017-07-17 18:00 +0200

csiph-web