Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1689122

Re: [f2fs-dev] [PATCH v2] f2fs: avoid cpu lockup

Show all headers | View raw

On 2017/7/16 9:04, Jaegeuk Kim wrote:
> Before retrying to flush data or dentry pages, we need to release cpu in order
> to prevent watchdog.
> 
> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>

Reviewed-by: Chao Yu <yuchao0@huawei.com>

> ---
> Change log from v1:
>  - timeout more specifically
> 
>  fs/f2fs/checkpoint.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/fs/f2fs/checkpoint.c b/fs/f2fs/checkpoint.c
> index 56bbf592e487..5b876f6d3f6b 100644
> --- a/fs/f2fs/checkpoint.c
> +++ b/fs/f2fs/checkpoint.c
> @@ -879,6 +879,7 @@ int sync_dirty_inodes(struct f2fs_sb_info *sbi, enum inode_type type)
>  	struct inode *inode;
>  	struct f2fs_inode_info *fi;
>  	bool is_dir = (type == DIR_INODE);
> +	unsigned long ino = 0;
>  
>  	trace_f2fs_sync_dirty_inodes_enter(sbi->sb, is_dir,
>  				get_pages(sbi, is_dir ?
> @@ -901,8 +902,17 @@ int sync_dirty_inodes(struct f2fs_sb_info *sbi, enum inode_type type)
>  	inode = igrab(&fi->vfs_inode);
>  	spin_unlock(&sbi->inode_lock[type]);
>  	if (inode) {
> +		unsigned long cur_ino = inode->i_ino;
> +
>  		filemap_fdatawrite(inode->i_mapping);
>  		iput(inode);
> +		/* We need to give cpu to another writers. */
> +		if (ino == cur_ino) {

We failed to flush dirty pages of inode due to encountering -EAGAIN of writepage?

Thanks,

> +			congestion_wait(BLK_RW_ASYNC, HZ/50);
> +			cond_resched();
> +		} else {
> +			ino = cur_ino;
> +		}
>  	} else {
>  		/*
>  		 * We should submit bio, since it exists several
> 

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] f2fs: avoid cpu lockup Jaegeuk Kim <jaegeuk@kernel.org> - 2017-07-15 03:30 +0200
  Re: [PATCH v2] f2fs: avoid cpu lockup Jaegeuk Kim <jaegeuk@kernel.org> - 2017-07-16 03:10 +0200
    Re: [f2fs-dev] [PATCH v2] f2fs: avoid cpu lockup Chao Yu <chao@kernel.org> - 2017-07-17 16:40 +0200
      Re: [f2fs-dev] [PATCH v2] f2fs: avoid cpu lockup Jaegeuk Kim <jaegeuk@kernel.org> - 2017-07-18 00:40 +0200
        Re: [f2fs-dev] [PATCH v2] f2fs: avoid cpu lockup Chao Yu <yuchao0@huawei.com> - 2017-07-18 03:50 +0200

csiph-web