[PATCH] [v2] [media] usbvision-i2c: fix format overflow warning

Path	csiph.com!goblin2!goblin.stu.neva.ru!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod
From	Arnd Bergmann <arnd@arndb.de>
Newsgroups	linux.kernel
Subject	[PATCH] [v2] [media] usbvision-i2c: fix format overflow warning
Date	Mon, 17 Jul 2017 16:40:02 +0200
Message-ID	<u4flM-6ht-15@gated-at.bofh.it> (permalink)
X-Original-To	Hans Verkuil <hverkuil@xs4all.nl>, Mauro Carvalho Chehab <mchehab@kernel.org>
X-Mailer	git-send-email 2.9.0
X-Provags-ID	V03:K0:5WKkg8wP20R/GTtomQDY+b7rb4DRcQLwvLb5A6s3n2lQbmULLDy pXAfLlGI27QpJ22t+atI71sUHIX0hXF4MA3PJPPTj8RNEZIOkGy6bsksac1pfRbPAogUGDG sg8BeS9ufzGniI7qFDDhSiteBDVm23VQYrzmvfFRVtYcFnuYxgEU+b5AZ7wYyAYBIj1/WEM tOXDtlBl5uzJtFKfDOFNA==
X-Ui-Out-Filterresults	notjunk:1;V01:K0:UH9kr4Idt2A=:tevAaSviuHlP0KHw60btEJ r09iaqGD1amu1cwjJKdrN66HmzbbEyTOhkfSncchlIN6XVYx8p6GwW2bmPFTXcB+pHpr6kRuf WSf3WVbZ9fPyanlaUyxpULsIhH7ikU8lSJtyCZDaI8pDCx4/q+D9Q+W0qVdDFZrYWBIk5U4AJ g1oRAW0CCVcdLqKGBRE2R91CagvMSzVkZZ3V2EjXsVqZdnCGhGk+9U8JXjkshii49ZgC/ykjb vtxwoKJCNWKu3eke1f3gbdq/pMAZh8OR4d3jJ3kfLpYkB+AmOhxoESF+uIeAKXKeDFXarMl1n Wr75cjiHXZAbQWKKX8lYl1KnKVZPGK93Pys9oMSOAh3dsXhiry1/dIWA0/8gzdoBjYC/qlDqK RuYU75uue30n4/qLIANKK7HNcnCCUGJuXHqOWbgBeY9a7aSFJnBuHvPl87SDdHihjF8eFdjvw qqjrzY0qMIO6C1R+p1DrUTE8JjGUITKavVK2+wvIdUuiqW9yJ/Bzyj7f4HrNhIETg2MZhT0fk soEcNEV10hZ/DOVG6OIrwPdBjLfkvuWNTelLtZ458UiGIkPme3H5flGtiNAN24oejDYm9Fv9b JUpcbB21v9OUW6naBmw/SR+aB+xK1JtKgmJ/N6htRJGgPRzMendhjwJ7CTQHVE9df3rpacw7V y8gG42NJGitgA1q7SyYKooX6iLmPfZZQCRMXSYrXWsaTY7SmeI3e9a/uOrppb3722vLlBePuf 9zqqLVYj5kJmkAuiOj5XiKYX/XpqYFPKZTFbOA==
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	40
Organization	linux.* mail to news gateway
X-Original-Cc	Arnd Bergmann <arnd@arndb.de>, Sakari Ailus <sakari.ailus@linux.intel.com>, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
X-Original-Date	Mon, 17 Jul 2017 16:29:58 +0200
X-Original-Message-ID	<20170717143024.862161-1-arnd@arndb.de>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1689111

Show key headers only | View raw

gcc-7 notices that we copy a fixed length string into another
string of the same size, with additional characters:

drivers/media/usb/usbvision/usbvision-i2c.c: In function 'usbvision_i2c_register':
drivers/media/usb/usbvision/usbvision-i2c.c:190:36: error: '%d' directive writing between 1 and 11 bytes into a region of size between 0 and 47 [-Werror=format-overflow=]
  sprintf(usbvision->i2c_adap.name, "%s-%d-%s", i2c_adap_template.name,
                                    ^~~~~~~~~~
drivers/media/usb/usbvision/usbvision-i2c.c:190:2: note: 'sprintf' output between 4 and 76 bytes into a destination of size 48

Using snprintf() makes the code more robust in general, but will still
trigger a possible warning about truncation in the string.
We know this won't happen as the template name is always "usbvision", so
we can easily avoid the warning as well by using this as the format string
directly.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
v2: use snprintf()
---
 drivers/media/usb/usbvision/usbvision-i2c.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/media/usb/usbvision/usbvision-i2c.c b/drivers/media/usb/usbvision/usbvision-i2c.c
index fdf6b6e285da..38749331e7df 100644
--- a/drivers/media/usb/usbvision/usbvision-i2c.c
+++ b/drivers/media/usb/usbvision/usbvision-i2c.c
@@ -187,8 +187,9 @@ int usbvision_i2c_register(struct usb_usbvision *usbvision)
 
 	usbvision->i2c_adap = i2c_adap_template;
 
-	sprintf(usbvision->i2c_adap.name, "%s-%d-%s", i2c_adap_template.name,
-		usbvision->dev->bus->busnum, usbvision->dev->devpath);
+	snprintf(usbvision->i2c_adap.name, sizeof(usbvision->i2c_adap.name),
+		 "usbvision-%d-%s",
+		 usbvision->dev->bus->busnum, usbvision->dev->devpath);
 	PDEBUG(DBG_I2C, "Adaptername: %s", usbvision->i2c_adap.name);
 	usbvision->i2c_adap.dev.parent = &usbvision->dev->dev;
 
-- 
2.9.0

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH] [v2] [media] usbvision-i2c: fix format overflow warning Arnd Bergmann <arnd@arndb.de> - 2017-07-17 16:40 +0200

csiph-web