Re: [PATCH 1/1] netfilter: nf_ct_expect: fix expect removal

From	Pablo Neira Ayuso <pablo@netfilter.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/1] netfilter: nf_ct_expect: fix expect removal
Date	2017-07-17 17:20 +0200
Message-ID	<u4fYu-6Lq-9@gated-at.bofh.it> (permalink)
References	<u4fOO-6GU-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Jiri,

On Mon, Jul 17, 2017 at 05:06:48PM +0200, Jiri Slaby wrote:
> Commit ec0e3f01114a ("netfilter: nf_ct_expect: Add
> nf_ct_remove_expect()") introduced a helper nf_ct_remove_expect. It was
> used over the code, but one location used a wrong variable and it
> resulted in a crash in this call stack:
>   -> nf_ct_expect_related_report
>   -> nf_ct_remove_expect
>   -> del_timer
>   -> detach_if_pending
> 
> Switch to the proper variable.
> 
> Fixes: ec0e3f01114a
> Signed-off-by: Jiri Slaby <jslaby@suse.cz>

I have pushed out a similar fix from Florian:

https://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf.git/commit/?id=36ac344e16e04e3e55e8fed7446095a6458c64e6

Thanks for the fix anyway.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/1] netfilter: nf_ct_expect: fix expect removal Jiri Slaby <jslaby@suse.cz> - 2017-07-17 17:10 +0200
  Re: [PATCH 1/1] netfilter: nf_ct_expect: fix expect removal Pablo Neira Ayuso <pablo@netfilter.org> - 2017-07-17 17:20 +0200

csiph-web