Re: [PATCH] rbd: Fix uninitialized variable use in rbd_acquire_lock

Path	csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	Ilya Dryomov <idryomov@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] rbd: Fix uninitialized variable use in rbd_acquire_lock
Date	Mon, 17 Jul 2017 17:10:01 +0200
Message-ID	<u4fON-6GU-5@gated-at.bofh.it> (permalink)
References	<u2Hcu-2Mh-17@gated-at.bofh.it> <u35HP-1Xa-13@gated-at.bofh.it> <u36Xg-2Gt-3@gated-at.bofh.it>
X-Original-To	Kefeng Wang <wangkefeng.wang@huawei.com>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=Uh+0JcSOHeTOss1gswP3fvyxDjrpQxDk+OcoRh8ckNw=; b=P0395rghhosxverE2YU/N3tcjAP2soNGrJDj0NaVP/zTf/OPSTxRszyc9K5mVeAkSm +wUO7Mg4olxeSDwL0zZ4uglDJxZlETpJX2k1tVMxhJmMd9N8+OMmuOACDh3CkEjWhR6X CkHBo1Y4U1lhLGrbOU8cDcuyWfaEczqSpqyIG6/M6XuB+oyDoPDd6yeS2/7xmz3w5EM8 4Iz5wmi49fv2E7WXpRr/Fr88k6m7nS8oEXXD0LSmQu00c3x4hAadwswtHeHMfpXg+9KB ABjv3O1pz5lYIU/HXfSNUpU0bACba5N5J9ir64afgcevKlh1iGUP4b7fozxXi1TSS+Kg QSzg==
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=Uh+0JcSOHeTOss1gswP3fvyxDjrpQxDk+OcoRh8ckNw=; b=igIjYfJ/9RG6hbOlnAlTPtvecyHrfx2g+ICalKvZdge+kdNgDL9XG3gL6zRX2rC1xB JRsAh9SPptqcl0z1ug7UwcFfzY3Ce4C3GM6sIBNikBlpRGrpanaokJsUkNcxH+ToZabQ Al2BMQLQPxwWUUf0fIfpAkamlFhLi0BjWgtMpmSZ/HhWKEmRCyLtYTUuEuhBHTIV61Wa +SQlu3dk09bW86ehdU1lgYCgEFtrXTmQiUxrduNTbwMEyyU2C/a7/A7qa88Rk0dUyIJi rovkkTnHO+zbCwCe0kcpZxP+Nlsx+gYL4YQSFlP22NBTWUeMV683o+jAhRI3pX4T1KBD 3uog==
X-Gm-Message-State	AIVw110Spazz8KRI1+zkoIfSreWZdyIibb87ihCk+h4Hk75+5KGt8k5R EI57iCj/XVXykiBNwiS/iaP9TpLFaw==
X-Received	by 10.31.84.130 with SMTP id i124mr12135423vkb.41.1500304103929; Mon, 17 Jul 2017 08:08:23 -0700 (PDT)
MIME-Version	1.0
Content-Type	text/plain; charset="UTF-8"
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	39
Organization	linux.* mail to news gateway
X-Original-Cc	Sage Weil <sage@redhat.com>, Alex Elder <elder@kernel.org>, Mike Christie <mchristi@redhat.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
X-Original-Date	Mon, 17 Jul 2017 17:08:23 +0200
X-Original-Message-ID	<CAOi1vP9C3Lh5k1g=Q-g4LJzjGFHg8mctftHVtt_65a5oPQC1Tw@mail.gmail.com>
X-Original-References	<1499931995-64900-1-git-send-email-wangkefeng.wang@huawei.com> <CAOi1vP8cn91_JXdM9nRSn7=7qMshxc2d4q4NCEC2hONsnPajYw@mail.gmail.com> <cfedb533-916a-5a5b-13f4-eb66cbe0d080@huawei.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1689157

Show key headers only | View raw

On Fri, Jul 14, 2017 at 1:25 PM, Kefeng Wang <wangkefeng.wang@huawei.com> wrote:
>
>
> On 2017/7/14 18:06, Ilya Dryomov wrote:
>> On Thu, Jul 13, 2017 at 9:46 AM, Kefeng Wang <wangkefeng.wang@huawei.com> wrote:
>>> drivers/block/rbd.c: In function 'rbd_acquire_lock':
>>> drivers/block/rbd.c:3602:44: error: 'ret' may be used uninitialized in this function [-Werror=maybe-uninitialized]
>>>
>>> Silence the warning, found it when built old kernel(3.10) with
>>> OBS(opensuse build service).
>>>
>>> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
>>> ---
>>>  drivers/block/rbd.c | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c
>>> index b008b6a..b640ad8 100644
>>> --- a/drivers/block/rbd.c
>>> +++ b/drivers/block/rbd.c
>>> @@ -3435,7 +3435,7 @@ static void rbd_acquire_lock(struct work_struct *work)
>>>         struct rbd_device *rbd_dev = container_of(to_delayed_work(work),
>>>                                             struct rbd_device, lock_dwork);
>>>         enum rbd_lock_state lock_state;
>>> -       int ret;
>>> +       int ret = 0;
>>>
>>>         dout("%s rbd_dev %p\n", __func__, rbd_dev);
>>>  again:
>>
>> How did you get rbd_acquire_lock() into 3.10?
>
> Using CentOS 7.3.

Applied.

Thanks,

                Ilya

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] rbd: Fix uninitialized variable use in rbd_acquire_lock Kefeng Wang <wangkefeng.wang@huawei.com> - 2017-07-13 10:00 +0200
  Re: [PATCH] rbd: Fix uninitialized variable use in rbd_acquire_lock Ilya Dryomov <idryomov@gmail.com> - 2017-07-14 12:10 +0200
    Re: [PATCH] rbd: Fix uninitialized variable use in rbd_acquire_lock Kefeng Wang <wangkefeng.wang@huawei.com> - 2017-07-14 13:30 +0200
      Re: [PATCH] rbd: Fix uninitialized variable use in rbd_acquire_lock Ilya Dryomov <idryomov@gmail.com> - 2017-07-17 17:10 +0200

csiph-web